Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Информативное описание workflow GHA #578

Merged
merged 1 commit into from
Jan 15, 2025
Merged

Информативное описание workflow GHA #578

merged 1 commit into from
Jan 15, 2025

Conversation

v-a-v
Copy link
Contributor

@v-a-v v-a-v commented Jan 15, 2025 •
edited
Loading

Pull Request description

Changelog

  • Some changes (A description of the changes proposed in the pull request.)

Issues

  • ONPREM-1388 (Link to related issue)

Breaking changes

  • If there are breaking changes, they need to be added to the file Breaking-Changes

Check-list. Чек-лист код-ревью

  • Запрос на слияние в develop.
  • Есть описание к PR.
  • Указаны блокирующие изменения. Breaking-Changes
  • Соответствие кода принятому стилю
    • Описание настроек.
    • Именование настроек.
    • Дефолтные значения.
    • Стиль кода.
  • Работоспособность. Разворачивается на своем окружении из ветки PR.
    • Тест API через тесты helmfile-хуков или коллекций Postman.
  • Не осталось мусора от удаления каких-то параметров. Ищется поиском по проекту из ветки PR.
  • Отработка линтера на чарт из ветки PR. Пример: helm lint charts/search-api

@v-a-v v-a-v requested review from a team as code owners January 15, 2025 06:01
@v-a-v v-a-v changed the title Инвормативное описание workflow Информативное описание workflow Jan 15, 2025
@v-a-v v-a-v changed the title Информативное описание workflow Информативное описание workflow GHA Jan 15, 2025
@v-a-v v-a-v merged commit 816fb0b into develop Jan 15, 2025
10 checks passed
@v-a-v v-a-v deleted the ONPREM-1388-2 branch January 15, 2025 07:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dbelyaev-nsk dbelyaev-nsk dbelyaev-nsk approved these changes

@endryhold endryhold endryhold approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@v-a-v @endryhold @dbelyaev-nsk