Improvements when using low_index to find covers #104
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…from complex_volume.c; call it in construct_cover; crash disappears??
* Require low_index 1.2 or newer. * Dealt with corner case of the trivial presentation.
unhyperbolic
approved these changes
May 17, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Triangulation.coverby not repeatedly calling the kernel functionfundamental_group.Triangulation.fundamental_groupreturns the trivial presentation.low_indexand so removedTriangulation._covers_low_index_old.The combination of 1 and 2 means that
low_indexbeats the SnapPea kernel in essentially all regimes.