Skip to content

Commit

Permalink
Merge branch 'MDL-83516-main-2' of https://github.com/meirzamoodle/mo…
Browse files Browse the repository at this point in the history
  • Loading branch information
HuongNV13 committed Dec 19, 2024
2 parents 7740336 + 508e77a commit 94b4520
Show file tree
Hide file tree
Showing 27 changed files with 373 additions and 335 deletions.
13 changes: 13 additions & 0 deletions .upgradenotes/MDL-83516-2024120309031139.yml
Original file line number Diff line number Diff line change
@@ -0,0 +1,13 @@
issueNumber: MDL-83516
notes:
tool_mfa:
- message: >-
The new factor management table uses `plugin_management_table`, so not only the functions that changed, but the file needs to be
moved from `admin/tool/mfa/classes/local/admin_setting_managemfa.php` to `admin/tool/mfa/classes/table/admin_setting_managemfa.php`
type: improved
- message: >-
The two language strings in the tool_mfa plugin, namely `inputrequired` and `setuprequired`, are deprecated.
type: deprecated
- message: >-
Introduce the new language string `settings:shortdescription`, which is mandatory for each factor.
type: improved
276 changes: 0 additions & 276 deletions admin/tool/mfa/classes/local/admin_setting_managemfa.php

This file was deleted.

12 changes: 12 additions & 0 deletions admin/tool/mfa/classes/local/factor/object_factor_base.php
Original file line number Diff line number Diff line change
Expand Up @@ -134,6 +134,18 @@ public function get_display_name(): string {
return get_string('pluginname', 'factor_'.$this->name);
}

/**
* Returns factor short description from language string.
*
* Base class implementation.
*
* @return string
* @throws \coding_exception
*/
public function get_short_description(): string {
return get_string('settings:shortdescription', 'factor_'.$this->name);
}

/**
* Returns factor help from language string.
*
Expand Down
Loading

0 comments on commit 94b4520

Please sign in to comment.