UX - Display an error message if the layer is not found in the CFG file, if admin #5304
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Gustry
added
administration pages
javascript
mdouchin
requested changes
Jan 30, 2025
Gustry
force-pushed
the
admin-layer-cfg
branch
from
1902a6c to
b388246
Compare
Gustry
force-pushed
the
admin-layer-cfg
branch
from
b388246 to
a503f35
Compare
nboisteault
approved these changes
Jan 30, 2025
Gustry
force-pushed
the
admin-layer-cfg
branch
2 times, most recently
from
3e5e035 to
e706c65
Compare
Gustry
force-pushed
the
admin-layer-cfg
branch
from
e706c65 to
82133d5
Compare
|
I'm keen to have feedbacks about this I didn't look too much |
Where is the issue? |
|
rldhont
requested changes
Jan 31, 2025
Comment on lines
+418
to
+423
| try { | ||
| // document is not defined in JUnit | ||
| if (document.body.dataset.lizmapAdminUser === 1) { | ||
| lizMap.addMessage(errorMessage, 'warning', true).attr('id', 'lizmap-warning-message'); | ||
| } | ||
| }catch(error) {} |
There was a problem hiding this comment.
Suggested change
| try { | |
| // document is not defined in JUnit | |
| if (document.body.dataset.lizmapAdminUser === 1) { | |
| lizMap.addMessage(errorMessage, 'warning', true).attr('id', 'lizmap-warning-message'); | |
| } | |
| }catch(error) {} |
Do not use LizMap or do some UX here.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I'm keen to have some feedbacks here.
For now, globally in Lizmap, if an error occurs, there is nothing displayed in the user interface. The only way is to open the developer tools, which is not a good advice, our admin end-users shouldn't open the web developer tools.
It would be nice, at the end of loading a map, a UI box is displayed if there were any "error" during loading the map ?
Just to keen to have ideas