Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Metadata - Add WFS link if the user has enough rights #5305

Draft
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

mdouchin
Copy link
Collaborator

Ticket : #

Funded by

@github-actions github-actions bot added this to the 3.10.0 milestone Jan 30, 2025
@mdouchin mdouchin force-pushed the metadata-add-wfs-url branch from fef7b65 to 991c476 Compare January 30, 2025 16:08
Copy link
Member

@Gustry Gustry left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a quick review for now.

I can come after to move the lizmap/www/assets/js/admin/copy_to_clipboard.js into the "public" assets and add the button ? Usually, opening the GetCapabilities is not what people want, they just want to copy/paste. (or having the URL in a <pre></pre>)

@@ -54,12 +54,17 @@
<dd><small class="bbox">{$WMSExtent}</small></dd>
<br/>

{ifacl2 'lizmap.tools.displayGetCapabilitiesLinks'}
{if $wmsGetCapabilitiesUrl}
<dt>{@view~map.metadata.properties.wmsGetCapabilitiesUrl@}</dt>
<dd><small><a href="{$wmsGetCapabilitiesUrl}" target="_blank">WMS Url</a></small></dd>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
<dd><small><a href="{$wmsGetCapabilitiesUrl}" target="_blank">WMS Url</a></small></dd>
<dd><small><a href="{$wmsGetCapabilitiesUrl}" target="_blank">WMS URL</a></small></dd>

{if $wmsGetCapabilitiesUrl}
<dt>{@view~map.metadata.properties.wmsGetCapabilitiesUrl@}</dt>
<dd><small><a href="{$wmsGetCapabilitiesUrl}" target="_blank">WMS Url</a></small></dd>
<dd><small><a id="metadata-wmts-getcapabilities-url" href="{$wmtsGetCapabilitiesUrl}" target="_blank">WMTS Url</a></small></dd>
{ifacl2 'lizmap.tools.layer.export'}
<dd><small><a href="{$wfsGetCapabilitiesUrl}" target="_blank">WFS Url</a></small></dd>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
<dd><small><a href="{$wfsGetCapabilitiesUrl}" target="_blank">WFS Url</a></small></dd>
<dd><small><a href="{$wfsGetCapabilitiesUrl}" target="_blank">WFS URL</a></small></dd>

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants