-
-
Notifications
You must be signed in to change notification settings - Fork 146
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Tests e2e playwright print refactoring #5324
Conversation
87ca4d1
to
28e6dca
Compare
If needed, I have added a commit on master : 4a99be4 |
… print in popup requests
… requests base layers
28e6dca
to
93251d2
Compare
Not related failing test : cypress external_wms_layer-ghaction.js |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
We can improve the tests after this PR
The backport to
stderr
stdout
To backport manually, run these commands in your terminal: # Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add .worktrees/backport-release_3_8 release_3_8
# Navigate to the new working tree
cd .worktrees/backport-release_3_8
# Create a new branch
git switch --create backport-5324-to-release_3_8
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick 7d8f3fe570c807ad31298b8dc4e129ba52354e9f,4be146de899711bcac741b2946fc1b360db79f71,552b7b41a6808b46b35bab07a1a2dd235edf9185,6a8d4cf397171402de7c053c2d1ed536922e65b8,b61928c105f152c1d3bf516f6c25e831a24064e7,53ea192ba80b06f24521e64b6259eb67c8012008,be766ae45682df147b43adc22c3284b2f92b2e3e,707808bbc913527718aea51b2004bbb1fd3a3054,4b44369cf901df6d998dcd871bcfae926e5971da,f9aba8204fde304a512a4f6fdff905b0c0e483dd,a3f9d3816897623521f8ba8a7d5616c3d081728a,93251d29ccb53a500a3e68a44e4cad1fffe5932f
# Push it to GitHub
git push --set-upstream origin backport-5324-to-release_3_8
# Go back to the original working tree
cd ../..
# Delete the working tree
git worktree remove .worktrees/backport-release_3_8 Then, create a pull request where the |
The backport to
stderr
stdout
To backport manually, run these commands in your terminal: # Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add .worktrees/backport-release_3_9 release_3_9
# Navigate to the new working tree
cd .worktrees/backport-release_3_9
# Create a new branch
git switch --create backport-5324-to-release_3_9
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick 7d8f3fe570c807ad31298b8dc4e129ba52354e9f,4be146de899711bcac741b2946fc1b360db79f71,552b7b41a6808b46b35bab07a1a2dd235edf9185,6a8d4cf397171402de7c053c2d1ed536922e65b8,b61928c105f152c1d3bf516f6c25e831a24064e7,53ea192ba80b06f24521e64b6259eb67c8012008,be766ae45682df147b43adc22c3284b2f92b2e3e,707808bbc913527718aea51b2004bbb1fd3a3054,4b44369cf901df6d998dcd871bcfae926e5971da,f9aba8204fde304a512a4f6fdff905b0c0e483dd,a3f9d3816897623521f8ba8a7d5616c3d081728a,93251d29ccb53a500a3e68a44e4cad1fffe5932f
# Push it to GitHub
git push --set-upstream origin backport-5324-to-release_3_9
# Go back to the original working tree
cd ../..
# Delete the working tree
git worktree remove .worktrees/backport-release_3_9 Then, create a pull request where the |
Refactoring print end2end playwright tests.