Fix tests e2e playwright JS module #5376
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rldhont
added
tests
rldhont
force-pushed
the
fix-playwright-js-module
branch
from
3da9181 to
79cc2c3
Compare
rldhont
added
run end2end
rldhont
force-pushed
the
fix-playwright-js-module
branch
4 times, most recently
from
9a2de80 to
154c067
Compare
Gustry
reviewed
Feb 7, 2025
Introduced by 3liz#5362, import of Lizmap JS module could not be done. So playwright has to be a `module` package, `require` has to be replaced by `import` and `__dirname` defined at each file level if needed.
rldhont
force-pushed
the
fix-playwright-js-module
branch
from
154c067 to
7e1277f
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Introduced by #5362, import of Lizmap JS module could not be done.
So playwright has to be a
modulepackage,requirehas to be replaced byimportand__dirnamedefined at each file level if needed.