Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

basereconciler v0.4 #10

Merged
merged 20 commits into from
Jan 8, 2024
Merged

basereconciler v0.4 #10

merged 20 commits into from
Jan 8, 2024

Conversation

roivaz
Copy link
Member

@roivaz roivaz commented Dec 12, 2023 •
edited
Loading

Make basereconciler a generic configurable resource reconciler, using the Update verb.

See https://github.com/3scale-ops/basereconciler/blob/e9a8f344824575d87ecbb743ca1a2a2522e98254/README.md for an overview

/kind feature
/priority important-longterm
/assign

@3scale-robot
Copy link
Contributor

@roivaz: The label(s) kind/feature, priority/important-longterm cannot be applied, because the repository doesn't have them.

In response to this:

Make basereconciler a generic configurable resource reconciler, using the Update verb.

/kind feature
/priority important-longterm
/assign

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@3scale-robot 3scale-robot added needs-kind Indicates a PR or issue lacks a `kind/foo` label and requires one. needs-priority Indicates a PR or issue lacks a `priority/foo` label and requires one. needs-size Indicates a PR or issue lacks a `size/foo` label and requires one. size/XL Requires about a week to complete the PR or the issue. and removed needs-size Indicates a PR or issue lacks a `size/foo` label and requires one. labels Dec 12, 2023
@roivaz roivaz force-pushed the basereconciler-v0.4 branch 2 times, most recently from 68e0844 to 1e6c45f Compare December 12, 2023 16:53
@roivaz
Copy link
Member Author

roivaz commented Dec 12, 2023

/retitle wip Basereconciler v0.4

@3scale-robot 3scale-robot changed the title Basereconciler v0.4 wip Basereconciler v0.4 Dec 12, 2023
@roivaz roivaz force-pushed the basereconciler-v0.4 branch 2 times, most recently from 758daaf to be149ae Compare December 14, 2023 16:50
roivaz added 12 commits December 15, 2023 11:46
@roivaz
Generalize resource reconciliation
bb3cd3a 
Combining the usage of go generics, client.Object interface, runtime.Unstructured
and jsonpath library from 'https://github.com/ohler55/ojg' the reconciliation
logic can be completely generalized for any resource GVK.
The idea is to that using the Update verb, the reconciler only cares
about the properties that the user configures in the resource template
or in the global configuration registry. Any other property is ignored
during resource diff to avoid updates when other entities modify the
resource (other controllers, webhooks, default values ...)
@roivaz
Add documentation
629bdfa
@roivaz
Merge status and reconciler packages
0390a84
@roivaz
Logger as part of the basereconciler
8c0cd60
@roivaz
Prettier API
47b2653
@roivaz
Add basic README.md
4ffecb6
@roivaz
Some small improvements
b4e057c
@roivaz
Fix requeue/return logic
2fb41b7
@roivaz
Separate resource diff code from update code
b5a788c
@roivaz
Rename GetInstance to ManageResourceLifecyle and improve option seman…
4c917d0 
…tics
@roivaz
Update README example with latest changes
150eecc
@roivaz
Fix bug in tests
23ee58a
@roivaz roivaz force-pushed the basereconciler-v0.4 branch from 709fdcf to 23ee58a Compare December 15, 2023 10:46
@roivaz roivaz force-pushed the basereconciler-v0.4 branch from 46f7bd9 to af6628c Compare December 15, 2023 15:00
@roivaz
Copy link
Member Author

roivaz commented Dec 15, 2023

/retitle basereconciler v0.4

@3scale-robot 3scale-robot changed the title wip Basereconciler v0.4 basereconciler v0.4 Dec 15, 2023
@roivaz
Copy link
Member Author

roivaz commented Dec 18, 2023

/kind feature
/priority important-longterm

@3scale-robot 3scale-robot added kind/feature Categorizes issue or PR as related to a new feature. priority/important-longterm Important over the long term, but may not be staffed and/or may need multiple sprints to complete. and removed needs-kind Indicates a PR or issue lacks a `kind/foo` label and requires one. needs-priority Indicates a PR or issue lacks a `priority/foo` label and requires one. labels Dec 18, 2023
slopezz
slopezz reviewed Dec 20, 2023
View reviewed changes
README.md Outdated Show resolved Hide resolved
slopezz
slopezz reviewed Dec 20, 2023
View reviewed changes
README.md Outdated Show resolved Hide resolved
slopezz
slopezz reviewed Dec 20, 2023
View reviewed changes
README.md Outdated Show resolved Hide resolved
slopezz
slopezz reviewed Dec 20, 2023
View reviewed changes
resource/template.go Outdated Show resolved Hide resolved
@3scale-robot 3scale-robot added the lgtm Indicates that a PR is ready to be merged. label Dec 21, 2023
@3scale-robot
Copy link
Contributor

LGTM label has been added.

Git tree hash: a5e46efa49866e05b9fd5516c20e911598b1d1df

@roivaz
Copy link
Member Author

roivaz commented Jan 8, 2024

/approve

@3scale-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: roivaz

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@3scale-robot 3scale-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jan 8, 2024
@3scale-robot 3scale-robot merged commit 211a3a8 into main Jan 8, 2024
3 checks passed
@3scale-robot 3scale-robot deleted the basereconciler-v0.4 branch January 8, 2024 09:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@slopezz slopezz slopezz approved these changes

@raelga raelga Awaiting requested review from raelga

Assignees

@roivaz roivaz

@slopezz slopezz

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. kind/feature Categorizes issue or PR as related to a new feature. lgtm Indicates that a PR is ready to be merged. priority/important-longterm Important over the long term, but may not be staffed and/or may need multiple sprints to complete. size/XL Requires about a week to complete the PR or the issue.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@roivaz @3scale-robot @slopezz