Fix pylint error rename (#876)

* Revert "Implement podman and docker container runtimes support"

This reverts commit 115c312.

* Ignore too-many-positional-arguments check

Pipfile

@@ -46,8 +46,6 @@ cfssl = "==0.0.3b243"
 openshift-client = ">=2.0.1"
 hyperfoil-client="*"
 paramiko = "*"
-docker = "*"
-podman = "*"
 jsondiff = "*"
 weakget = "*"
 flaky = "*"

doc/examples.py

@@ -136,70 +136,3 @@ def test_skip_apicast_retrying_on_404(application, api_client):
     client = api_client(disable_retry_status_list={404})
 
     assert client.get("/status/404").status_code == 404
-
-
-################################################################################
-# Example usage of DockerRuntime
-def example_docker():
-    from testsuite.containers.docker_runtime import DockerRuntime
-    from testsuite.containers.container_runtime import ContainerConfig
-    from contextlib import closing
-
-    with closing(DockerRuntime("tcp://10.0.145.159:2376")) as d:
-        cc = ContainerConfig("mysql", "latest", {"MYSQL_ROOT_PASSWORD": "root"}, {"3306": "33767"}, cmd=["ls", "-la"])
-        cc.attach_volume("/root/dkr", "/mnt")
-        c = d.run(cc)
-        print(d.logs(c))
-
-        # d.stop(c)
-        d.delete_container(c)
-
-
-###############################################################################
-# Example usage of PodmanRuntime
-def example_podman():
-    from testsuite.containers.podman_runtime import PodmanRuntime
-    from testsuite.containers.container_runtime import ContainerConfig
-    from contextlib import closing
-
-    with closing(PodmanRuntime("ssh://[email protected]/run/podman/io.podman")) as d:
-        cc = ContainerConfig("mysql", "latest", {"MYSQL_ROOT_PASSWORD": "root"}, {"3306": "33075"}, cmd=["ls"])
-        cc.attach_volume("/root/blah", "/mnt")
-        c = d.run(cc)
-        print(d.logs(c))
-        # d.stop(c)
-        d.delete_container(c)
-
-
-###############################################################################
-# Example usage of DockerRuntime
-def example_docker_no_cm():
-    from testsuite.containers.docker_runtime import DockerRuntime
-    from testsuite.containers.container_runtime import ContainerConfig
-
-    d = DockerRuntime("tcp://10.0.145.159:2376")
-    cc = ContainerConfig("mysql", "latest", {"MYSQL_ROOT_PASSWORD": "root"}, {"3306": "33767"}, cmd=["ls", "-la"])
-    cc.attach_volume("/root/dkr", "/mnt")
-    c = d.run(cc)
-    print(d.logs(c))
-
-    # d.stop(c)
-    d.delete_container(c)
-    d.close()
-
-
-###############################################################################
-# Example usage of PodmanRuntime
-def example_podman_no_cm():
-    from testsuite.containers.podman_runtime import PodmanRuntime
-    from testsuite.containers.container_runtime import ContainerConfig
-
-    d = PodmanRuntime("ssh://[email protected]/run/podman/io.podman")
-    cc = ContainerConfig("mysql", "latest", {"MYSQL_ROOT_PASSWORD": "root"}, {"3306": "33076"}, cmd=["ls"])
-    cc.attach_volume("/root/blah", "/mnt")
-    c = d.run(cc)
-    print(d.logs(c))
-    # d.stop(c)
-    d.delete_container(c)
-
-    d.close()

pylintrc

@@ -18,6 +18,7 @@ disable=duplicate-code,  # reports false alarms AND can't be disabled locally; p
 	consider-using-f-string,  # % string operator is absolutely fine
         redefined-outer-name,
         missing-timeout,  # socket timeout is set globally, no need to specify it in calls
+        too-many-positional-arguments,
 
 [FORMAT]
 # Maximum number of characters on a single line.

testsuite/tests/apicast/parameters/test_apicast_service_configuration_version.py

@@ -12,7 +12,7 @@
 
 pytestmark = [
     pytest.mark.required_capabilities(Capability.STANDARD_GATEWAY, Capability.CUSTOM_ENVIRONMENT),
-    pytest.mark.nopersistence  # Don't know why this test is failing with persistence plugin,
+    pytest.mark.nopersistence,  # Don't know why this test is failing with persistence plugin,
     # and it needs more investigation
 ]
 

testsuite/tests/apicast/test_limit_exceeded_metric.py

@@ -54,4 +54,3 @@ def test_anything_else_is_ok(api_client):
     """Call to /anything/else should return 200 OK."""
 
     assert api_client().get("/anything/else").status_code == 200
-