THREESCALE-11393: Upgrade the Dockefile for system image based on RHEL8 #1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mayorova
changed the title
akostadinov
reviewed
Oct 3, 2024
| @@ -1,4 +1,5 @@ | |||
| FROM registry.redhat.io/3scale-amp2/system-rhel7:3scale2.14 | |||
| # FROM registry.redhat.io/3scale-amp2/system-rhel8:3scale2.15 | |||
| FROM registry-proxy.engineering.redhat.com/rh-osbs/3scale-amp2-system-rhel8:1.17.0-529 | |||
There was a problem hiding this comment.
we should probably use a public image uri?
akostadinov
reviewed
Oct 3, 2024
Comment on lines
-10
to
+11
| ENV LD_LIBRARY_PATH=/opt/oracle/instantclient/:$LD_LIBRARY_PATH \ | ||
| ENV LD_LIBRARY_PATH=/opt/oracle/instantclient/ \ |
akostadinov
reviewed
Oct 3, 2024
Comment on lines
-16
to
+20
| RUN ./script/oracle/install-instantclient-packages.sh \ | ||
| && source /opt/app-root/etc/scl_enable \ | ||
| && DB=oracle bundle install --local --deployment --jobs $(grep -c processor /proc/cpuinfo) --retry=5 | ||
| RUN dnf install wget unzip make ruby-devel gcc gcc-c++ redhat-rpm-config libaio -y \ | ||
| && ./script/oracle/install-instantclient-packages.sh \ | ||
| && ln -s /usr/lib64/libnsl.so.2 /usr/lib64/libnsl.so.1 \ | ||
| && DB=oracle bundle install --jobs $(grep -c processor /proc/cpuinfo) --retry=5 |
There was a problem hiding this comment.
I assume this is the ultimate fix. The root of the issue is that when building the system image, we now remove most build dependencies to have a slimmer image.
I don't know if we support disconnected environments. But installing these deps during build will not work in such.
So the above is a valid solution for internet connected builds. Although I'm concerned about the nsl linking.
An alternative solution would be to ship also a builder image that will be used for this kind of builds 🤔
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update the
Dockerfilefor building a system image with Oracle dependencies, based on the system image from 3scale 2.15.https://issues.redhat.com/browse/THREESCALE-11393