Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ruby : Finalize mapping for Japanese version #598

Merged
merged 16 commits into from
Dec 27, 2024

Conversation

ThibaultLassiaz
Copy link
Collaborator

Description

Added support for every modes and listeners for Ruby JP.

This PR handle support of :

  • Accro Bike Bunny Hop
  • Berry Blender
  • Daycare
  • Feebas
  • Fishing
  • Level Grind
  • Puzzle Solver
  • Roamer Resets
  • Rock Smash
  • Spin
  • Starters
  • Static Gift Reset
  • Static Soft Reset
  • Sweet Scent

Fixed

Ruby and Sapphire appear to use a slightly different memory layout on Rev0 ROMs (Like JP ROMs). I made some minor adjustments to handle the bot features on Ruby JP.

  • Fixed Keyboard for Ruby JP
  • Fixed Berry blender memory reading for Ruby JP

Notes

I updated the state repo with a state master set

Checklist

  • Black Linter has been ran, using --line-length 120 argument
  • Wiki has been updated (if relevant)

@ThibaultLassiaz ThibaultLassiaz force-pushed the add-remaining-modes-ruby-jp branch from 3b422bc to 9cbbaa7 Compare December 27, 2024 18:42
@hanzi hanzi merged commit 7ea2e06 into 40Cakes:main Dec 27, 2024
1 check passed
@ThibaultLassiaz ThibaultLassiaz deleted the add-remaining-modes-ruby-jp branch December 27, 2024 21:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants