Limit total number of save states in Load State Window #616
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The Load State window crashes once a certain number of loadable states is reached. I haven't tested what that exact 'certain number' is. We are already limiting the number of autosaves we display to 3. But 'manual' save states (this includes those created with `Ctrl+S`, but also save states when encountering a shiny/CCF) are not filtered and/or limited. This PR adds a limit of 128 total save states. That number has been chosen arbitrarily, but it doesn't crash my test profile anymore so I guess that's alright.
pekempy
approved these changes
Jan 13, 2025
40Cakes
pushed a commit
that referenced
this pull request
Jan 22, 2025
The Load State window crashes once a certain number of loadable states is reached. I haven't tested what that exact 'certain number' is. We are already limiting the number of autosaves we display to 3. But 'manual' save states (this includes those created with `Ctrl+S`, but also save states when encountering a shiny/CCF) are not filtered and/or limited. This PR adds a limit of 128 total save states. That number has been chosen arbitrarily, but it doesn't crash my test profile anymore so I guess that's alright.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The Load State window crashes once a certain number of loadable states is reached. I haven't tested what that exact 'certain number' is.
We are already limiting the number of autosaves we display to 3.
But 'manual' save states (this includes those created with
Ctrl+S, but also save states when encountering a shiny/CCF) are not filtered and/or limited.This PR adds a limit of 128 total save states. That number has been chosen arbitrarily, but it doesn't crash my test profile anymore so I guess that's alright.
Checklist
--line-length 120argument