Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reorganize symbols (attempt to fix tests) #29

Merged
merged 2 commits into from
Jun 19, 2024
Merged

Conversation

svetlyak40wt
Copy link
Member

No description provided.

- jsonrpc restructured in recent changes.
  - call import from jsonrpc/base
  - client import from jsonrpc/client
  - bind-server-to-transport import from jsonrpc/server
- explicitly import-from symbols in openrpc-client/core
  and remove package qualifiers
- update README with jsonrpc/client:client
@kilianmh
Copy link
Contributor

Is the Github CI Blackbox saving or stealing more time?

@svetlyak40wt
Copy link
Member Author

@kilianmh I hate GitHub actions debugging.

Actually, there are tools like this one (https://github.com/mxschmitt/action-tmate) which allow to look inside the container. But environment will be different from what real code step sees.

@svetlyak40wt
Copy link
Member Author

@kilianmh what I'm trying to debug is why my fix for quicklisp is not applied inside the action.

This small patch (https://github.com/40ants/quicklisp-client-fix) fixes the way how Quicklisp client loads package-inferred dependencies. For example, if you'll try to load jsonrpc/client from the environment where there is no code for jsonrpc, then quicklisp client will fail, because it is unaware about the jsonrpc/client system. However, he knows about the primary system jsonrpc. And my fix make quicklisp try to load jsonrpc system first in such case.

@svetlyak40wt
Copy link
Member Author

Finally I was able to figure out the reason of this error:

; Loading "jsonrpc/server"

debugger invoked on a ASDF/FIND-COMPONENT:MISSING-COMPONENT in thread
#<THREAD tid=5789 "main thread" RUNNING {1000E28093}>:
  Component "jsonrpc/server" not found

On CI qlfile is empty and tries to load jsonrpc from Quicklisp where we still have an old version of code and there is no jsonrpc/server file.

@svetlyak40wt svetlyak40wt merged commit 58b7475 into master Jun 19, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants