improvement: clearing DateTimeInput #705
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gidomanders
force-pushed
the
improvement/datetimeinput-clear-value
branch
2 times, most recently
from
39f593d to
c2b5f5a
Compare
Manually clearing the input doesn't work. Only of you clear the input and change the date and clear it a second time, the value is actually cleared. Added clear button to clear the input as manually clearing the input is an issue within the react-datetime library that is not updated anymore. This allows for the DateTimeInput to support undefined in onChange. Closes #704
gidomanders
force-pushed
the
improvement/datetimeinput-clear-value
branch
from
c2b5f5a to
7dc0b60
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #705 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 131 131
Lines 2771 2781 +10
Branches 817 824 +7
=========================================
+ Hits 2771 2781 +10
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Manually clearing the input doesn't work. Only of you clear the input and change the date and clear it a second time, the value is actually cleared.
Added clear button to clear the input as manually clearing the input is an issue within the react-datetime library that is not updated anymore. This allows for the DateTimeInput to support undefined in onChange.
Closes #704