Skip to content
This repository has been archived by the owner on Sep 8, 2021. It is now read-only.

[seonkim, jiwlee, sucho] 졌잘싸 #1

Open
wants to merge 151 commits into
base: main
Choose a base branch
from
Open

[seonkim, jiwlee, sucho] 졌잘싸 #1

wants to merge 151 commits into from

Conversation

jiwlee97
Copy link

@jiwlee97 jiwlee97 commented Aug 23, 2021 •
edited
Loading

📘 Subject Name

RUSH00

📝 Note

  • 졌잘싸...

이지원 and others added 30 commits August 23, 2021 16:12
Use Router
808e356
url 변경
f4f89f6
@sungyongcho
init dev env
0c02500
package.json
0758470
npm install axios
c7018b3
@sungyongcho
port chagne
0148927
Merge branch 'main' into jiwlee
f86de0e
@sungyongcho
port num fix
b4e70e1
Merge branch 'main' into jiwlee
1db64b0
prettier 적용
44c5a2c
remove unusable parameter
4d519d6
@nfl1ryxditimo12
main branch 병합
b8e980a
proptype 적용
19b5c77
@nfl1ryxditimo12
db init
16b803b
@sungyongcho
Merge pull request #6 from sungyongcho/jiwlee
f13cf97 
LGTM
remove client dir
3e3bd33
@sungyongcho
Merge pull request #7 from sungyongcho/jiwlee
69c2ab0
@sungyongcho
hihi
d1715eb
@sungyongcho
eslint 적용
90e7417
@sungyongcho
Merge pull request #8 from sungyongcho/test
5f62561 
LGTM
add handleClickProfile
9745e12
Merge branch 'main' into jiwlee
cdfc9f3
@nfl1ryxditimo12
ing ..
c3312ba
@sungyongcho
Merge branch 'seonkim' of github.com:sungyongcho/piscine-rush00 into …
13b07d1 
…seonkim
@sungyongcho
server 수정중
b577f8f
@sungyongcho
Merge pull request #9 from sungyongcho/seonkim
7be9b26 
LGTM
@nfl1ryxditimo12
table/ -> model/ 이동
405897d
@nfl1ryxditimo12
Sequelize DB 연동
099ac3a
@sungyongcho
db/프론트 구성
f227a3b
@sungyongcho
mariadb 볼륨은 안올라감
77d7e54
@github-actions
Copy link

👋 안녕하세요! jiwlee97님!

  • 🎉 정상적으로 제출 되셨습니다! 평가 매칭을 기달려주세요!
  • PR 제출 기간: 2021-08-23 12:00:00 ~ 2021-08-24 23:41:59
  • PR 제출 시각: 2021-08-23 21:29:55
  • PR 마지막 업데이트 시각: 2021-08-24 21:58:26

@github-actions
Copy link

👋 안녕하세요! jiwlee97님!

  • 🎉 정상적으로 제출 되셨습니다! 평가 매칭을 기달려주세요!
  • PR 제출 기간: 2021-08-23 12:00:00 ~ 2021-08-24 23:41:59
  • PR 제출 시각: 2021-08-23 21:29:55
  • PR 마지막 업데이트 시각: 2021-08-24 23:40:15

@jiwlee97 jiwlee97 changed the title Jiwlee [seonkim, jiwlee, sucho] 졌잘싸 Aug 24, 2021
@JaeSeoKim JaeSeoKim requested review from a team, earthkingman and leekh716 and removed request for a team August 24, 2021 15:30
@JaeSeoKim
Copy link
Member

🎉 평가 매칭이 되셨습니다! 리뷰어를 확인후 아래의 주의 사항을 확인하여 진행 해주세요!

  • ⚠️ 평가시 주의 사항
    • 본과정과 동일 하게 위에서 틀린 경우 그 즉시 평가점수 부여는 멈춰야 합니다.
    • 평가를 진행 할때 PR의 CodeReview 기능을 이용해서 approve로 리뷰를 남겨주세요.
    • comment 로 작성하여 남겨주시면 스탭분들이 확인하는데 어려움을 격습니다 ㅠㅠ
    • PR 리뷰에 구글 폼 제출 후 나오는 점수 결과를 꼭 같이 제출 하여주세요!

leekh716
leekh716 approved these changes Aug 25, 2021
View reviewed changes
Copy link

@leekh716 leekh716 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

image
image
고생많이하셨습니다ㅜㅜ db연동에서 뭔가가 꼬인거같아서 아쉽네요 다들 고생하셨어요!

@earthkingman
Copy link

image
image

JWT 토큰 쿠키에 저장하신거 잘배웠습니다.
제 기준에서는 평가항목을 많이 갖추신것 같습니다.

earthkingman
earthkingman approved these changes Aug 25, 2021
View reviewed changes
Copy link

@earthkingman earthkingman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@earthkingman earthkingman earthkingman approved these changes

@leekh716 leekh716 leekh716 approved these changes

Assignees
No one assigned
Labels
RUSH00 ✅ 정상적인 제출
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@jiwlee97 @JaeSeoKim @earthkingman @leekh716 @sungyongcho @nfl1ryxditimo12