Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Playground/act test 1 #14

Merged
merged 57 commits into from
May 10, 2023
Merged

Playground/act test 1 #14

merged 57 commits into from
May 10, 2023

Conversation

ak0327
Copy link
Collaborator

@ak0327 ak0327 commented May 9, 2023

No description provided.

@ak0327 ak0327 linked an issue May 9, 2023 that may be closed by this pull request
github action test - test #13
Closed
@ak0327 ak0327 force-pushed the playground/act-test-1 branch from 5ea3647 to 008a3ef Compare May 10, 2023 01:52
@ak0327
Copy link
Collaborator Author

ak0327 commented May 10, 2023 •
edited
Loading

スクリプト面白いー
単純な出力文字列の判定はできた
NGの時のinput/outputは出力したいかも -> bats assert
memory leakのチェックまでできればと思いmainを用意したが、難しそう...!?

@habvi
Copy link
Collaborator

habvi commented May 10, 2023 •
edited
Loading

valgrind でできそう…？
ちょっと手間そうですがやりたいですね
GitHub Actions でリークテスト:)
あ、これ Docker だった…探せば leak check 系色々ありそう

@ak0327 ak0327 force-pushed the playground/act-test-1 branch from bff70f9 to be3dc6c Compare May 10, 2023 02:36
@ak0327
Copy link
Collaborator Author

ak0327 commented May 10, 2023 •
edited
Loading

leaks関係、statusで簡易的に評価できそうですねー
あ、leaksはmacなのでgithub actionのlinuxだと使えないのか

ak0327 added 17 commits May 10, 2023 13:07
@ak0327 ak0327 force-pushed the playground/act-test-1 branch from 8c85324 to 8a05cb5 Compare May 10, 2023 06:44
@ak0327 ak0327 marked this pull request as ready for review May 10, 2023 09:43
@ak0327 ak0327 requested a review from habvi May 10, 2023 09:44
habvi
habvi reviewed May 10, 2023
View reviewed changes
a.out Outdated Show resolved Hide resolved
@ak0327 ak0327 requested review from habvi and removed request for habvi May 10, 2023 10:51
@habvi habvi changed the base branch from main to dev May 10, 2023 10:52
@ak0327 ak0327 merged commit fcf2b62 into dev May 10, 2023
@habvi habvi deleted the playground/act-test-1 branch May 10, 2023 10:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@habvi habvi habvi approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

github action test - test
2 participants
@ak0327 @habvi