Add Edit gist api #240
Add Edit gist api #240
Conversation
| implicit val encodeEditGistFile: Encoder[EditGistFile] = { | ||
| deriveEncoder[EditGistFile].mapJsonObject(_.filter(e => | ||
| !(e._1.equals("filename") && e._2.isNull))) | ||
| } |
There was a problem hiding this comment.
You can move that to Encoders.scala 👍
There was a problem hiding this comment.
I tried first, but it seems like Encoders is not used here, when toJson is needed for implicit.
There was a problem hiding this comment.
I think you should be able to import it then, no?
|
@aleksandr-vin Could you please rebase against error] /github4s/shared/src/test/scala/github4s/unit/ReposSpec.scala:202: illegal start of simple expression
[error] )
[error] ^
[error] /github4s/shared/src/test/scala/github4s/unit/ReposSpec.scala:215: ')' expected but '}' found.
[error] }
[error] ^
[error] two errors found
[error] (github4sJVM/test:compileIncremental) Compilation failedUpdate: it seems it happens for Scala 2.11. |
- Add files property to domain.Gist Signed-off-by: Aleksandr Vinokurov <[email protected]>
Signed-off-by: Aleksandr Vinokurov <[email protected]>
- Add EditGistFile, EditGistRequest to domain Signed-off-by: Aleksandr Vinokurov <[email protected]>
Signed-off-by: Aleksandr Vinokurov <[email protected]>
aleksandr-vin
force-pushed
the
add-update-gist-api
branch
from
1b25902 to
093a71f
Compare
@juanpedromoreno done. |
|
Closes #237 as well |
|
What's are your release plans, guys? |
|
we usually do them on demand, so if you need one just shout 👍 |
|
@aleksandr-vin @BenFradet I'll send a fix for the random test failure, and then, I'll request a new release along with the build upgrade. |
|
I need one, as I'm in the process of some home project and need an update on heroku (that's why #242) ;) |
|
Done #243 The release should be completed shortly ;) |
Closes #238