fix: Update query state key from 'hello' to 'name' in BasicUsageDemo #665
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@kzhgit is attempting to deploy a commit to the 47ng Team on Vercel. A member of the Team first needs to authorize it. |
|
This is a duplicate of #611, and my comment there still stands: this would break existing URLs, and cool URLs don't break. That being said, I would accept a change of the key if there was a middleware doing the translation from the old key to the new one. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes a small issue in the BasicUsageDemo where the query state key was incorrectly set to 'hello'. The correct key should be 'name', as it more accurately represents the state being queried.
By making this adjustment, the code becomes clearer and aligns better with the expected functionality. I have tested the changes locally to ensure the demo behaves as intended with the updated key.