Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: adds info on extending PrismaClient type in readme #130

Open
wants to merge 1 commit into
base: next
Choose a base branch
from

Conversation

NGimbal
Copy link

@NGimbal NGimbal commented Oct 23, 2024

Relevant Github Issue:

#129

I added this in the default integration snippet because the snippet already uses Typescript, and my experience tells me it's important. Please let me know if you'd like me to keep that block of code more minimal and I can create a separate section that talks about extending the PrismaClient type.

Thanks again for your hard work on this library!

@coveralls
Copy link

Pull Request Test Coverage Report for Build 11470422894

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 79.242%

Totals Coverage Status
Change from base Build 11019901257: 0.0%
Covered Lines: 269
Relevant Lines: 320

💛 - Coveralls

Copy link
Member

@franky47 franky47 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! Yes I think this might be a bit verbose for the initial setup phase, I'd rather have this code block focusing on showcasing the fieldEncryptionExtension function (too bad we can't highlight lines on GitHub).

suggestion: Maybe we could move the TS-specifics into a <details><summary> block, with a title of something like "Typing the extended client with TypeScript", what do you think?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants