Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Drop python 3.9 tests for napari repository #1244

Merged
merged 1 commit into from
Feb 14, 2025

Conversation

Czaki
Copy link
Collaborator

@Czaki Czaki commented Feb 14, 2025

Ss napari drop python 3.9 stop testing i against napari repo

closes #1243

Summary by Sourcery

CI:

  • Remove Python 3.9 from the napari repository test matrix

Summary by CodeRabbit

  • Tests
    • Updated our automated testing configuration to focus on Python 3.10, 3.11, and 3.12 for enhanced compatibility and performance.

@Czaki Czaki added this to the 0.16.1 milestone Feb 14, 2025
Copy link
Contributor

sourcery-ai bot commented Feb 14, 2025

Reviewer's Guide by Sourcery

This pull request removes Python 3.9 from the test matrix in the test_napari_repo.yml workflow. This streamlines the testing process by focusing on actively supported Python versions.

No diagrams generated as the changes look simple and do not need a visual representation.

File-Level Changes

Change Details Files
Removed Python 3.9 from the test matrix.
  • Removed '3.9' from the python matrix in the test_napari_repo.yml workflow.
.github/workflows/test_napari_repo.yml

Assessment against linked issues

Issue Objective Addressed Explanation
#1243 Fix the failing tests on ubuntu-24.04 py3.9 in the napari repo workflow.

Possibly linked issues


Tips and commands

Interacting with Sourcery

  • Trigger a new review: Comment @sourcery-ai review on the pull request.
  • Continue discussions: Reply directly to Sourcery's review comments.
  • Generate a GitHub issue from a review comment: Ask Sourcery to create an
    issue from a review comment by replying to it. You can also reply to a
    review comment with @sourcery-ai issue to create an issue from it.
  • Generate a pull request title: Write @sourcery-ai anywhere in the pull
    request title to generate a title at any time. You can also comment
    @sourcery-ai title on the pull request to (re-)generate the title at any time.
  • Generate a pull request summary: Write @sourcery-ai summary anywhere in
    the pull request body to generate a PR summary at any time exactly where you
    want it. You can also comment @sourcery-ai summary on the pull request to
    (re-)generate the summary at any time.
  • Generate reviewer's guide: Comment @sourcery-ai guide on the pull
    request to (re-)generate the reviewer's guide at any time.
  • Resolve all Sourcery comments: Comment @sourcery-ai resolve on the
    pull request to resolve all Sourcery comments. Useful if you've already
    addressed all the comments and don't want to see them anymore.
  • Dismiss all Sourcery reviews: Comment @sourcery-ai dismiss on the pull
    request to dismiss all existing Sourcery reviews. Especially useful if you
    want to start fresh with a new review - don't forget to comment
    @sourcery-ai review to trigger a new review!
  • Generate a plan of action for an issue: Comment @sourcery-ai plan on
    an issue to generate a plan of action for it.

Customizing Your Experience

Access your dashboard to:

  • Enable or disable review features such as the Sourcery-generated pull request
    summary, the reviewer's guide, and others.
  • Change the review language.
  • Add, remove or edit custom review instructions.
  • Adjust other review settings.

Getting Help

Copy link
Contributor

coderabbitai bot commented Feb 14, 2025

Walkthrough

This pull request updates the CI workflow configuration for the napari repository. In the workflow file (.github/workflows/test_napari_repo.yml), the Python version matrix for the test_napari job is modified by removing Python 3.9. Only Python versions 3.10, 3.11, and 3.12 are now used for testing, while the remainder of the workflow remains unchanged.

Changes

File Change Summary
.github/workflows/test_napari_repo.yml Removed Python 3.9 from the test matrix; now testing on Python 3.10, 3.11, and 3.12.

Poem

I'm a rabbit with a joyful hop,
CI changes make my heart go pop!
Python 3.9 has hopped away,
Leaving room for a brighter day.
Carrots and code—hip hip hooray!


📜 Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between cc63206 and 9a7ea84.

📒 Files selected for processing (1)
  • .github/workflows/test_napari_repo.yml (1 hunks)
⏰ Context from checks skipped due to timeout of 300000ms (31)
  • GitHub Check: 4DNucleome.PartSeg (Tests_other test windows)
  • GitHub Check: 4DNucleome.PartSeg (Tests_other test macos)
  • GitHub Check: 4DNucleome.PartSeg (Tests_linux test_linux)
  • GitHub Check: 4DNucleome.PartSeg (Builds pyinstaller windows)
  • GitHub Check: 4DNucleome.PartSeg (Builds pyinstaller macos_arm)
  • GitHub Check: 4DNucleome.PartSeg (Builds pyinstaller macos)
  • GitHub Check: 4DNucleome.PartSeg (Builds pyinstaller_linux)
  • GitHub Check: 4DNucleome.PartSeg (Builds sdist)
  • GitHub Check: Base py3.9 / ubuntu-24.04 py 3.9 latest PyQt5
  • GitHub Check: Base py3.12 / ubuntu-24.04 py 3.12 latest PyQt5
  • GitHub Check: Base py3.12 / ubuntu-22.04 py 3.12 latest PyQt6
  • GitHub Check: Base py3.12 / macos-14 py 3.12 latest PyQt6
  • GitHub Check: Base py3.11 / windows-latest py 3.11 latest PyQt5
  • GitHub Check: Base py3.11 / macos-13 py 3.11 latest PyQt5
  • GitHub Check: Base py3.11 / ubuntu-24.04 py 3.11 latest PyQt5
  • GitHub Check: repo py3.12
  • GitHub Check: Base py3.10 / ubuntu-24.04 py 3.10 latest PySide6
  • GitHub Check: repo py3.11
  • GitHub Check: Base py3.10 / ubuntu-24.04 py 3.10 latest PyQt5
  • GitHub Check: repo py3.10
  • GitHub Check: Base py3.10 / ubuntu-22.04 py 3.10 latest PyQt5 _pydantic_1
  • GitHub Check: Base py3.10 / ubuntu-20.04 py 3.10 latest PySide2
  • GitHub Check: Test PartSeg minimal / ubuntu-24.04 py 3.9 latest PyQt5
  • GitHub Check: test_coverage / ubuntu-24.04 py 3.12 latest PyQt5
  • GitHub Check: Test PartSeg conda
  • GitHub Check: 4DNucleome.PartSeg (manifest_check manifest_check)
  • GitHub Check: 4DNucleome.PartSeg (GetTestData linux)
  • GitHub Check: 4DNucleome.PartSeg (Documentation_check Notebook_check)
  • GitHub Check: 4DNucleome.PartSeg (formatting_check check_formating)
  • GitHub Check: 4DNucleome.PartSeg (Documentation_check help)
  • GitHub Check: Codacy Static Code Analysis
🔇 Additional comments (1)
.github/workflows/test_napari_repo.yml (1)

37-37:

❓ Verification inconclusive

LGTM! Verify Python version support policy.

The removal of Python 3.9 from the test matrix aligns with the PR objective. However, please ensure this change is documented in:

  • Project's minimum Python version requirements
  • Release notes/changelog
  • Documentation about supported Python versions

Let's check the project's Python version requirements:


🏁 Script executed:

#!/bin/bash
# Check Python version requirements in key files
echo "Checking pyproject.toml..."
rg "python_requires|python_version" pyproject.toml

echo -e "\nChecking README..."
rg "python|Python" README.md

echo -e "\nChecking setup.py/setup.cfg if they exist..."
fd -e py -e cfg -x rg "python|Python" {} \;

Length of output: 1972


LGTM, with one note: The removal of Python 3.9 from the testing matrix meets the PR objective. However, please verify that the project’s Python version support policy and related documentation (e.g., minimum Python version in dependency configurations, release notes, and any user-facing docs) reflect this change. The search in the pyproject.toml shows conditional dependency declarations based on Python versions, but there's no explicit documentation update confirming the drop of Python 3.9 support. Could you please double-check or update the docs to confirm that Python 3.9 is no longer supported?


Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai generate docstrings to generate docstrings for this PR. (Beta)
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

Copy link
Contributor

@sourcery-ai sourcery-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @Czaki - I've reviewed your changes - here's some feedback:

Overall Comments:

  • Consider updating the minimum supported python version in setup.py and other relevant files.
Here's what I looked at during the review
  • 🟢 General issues: all looks good
  • 🟢 Security: all looks good
  • 🟢 Testing: all looks good
  • 🟢 Complexity: all looks good
  • 🟢 Documentation: all looks good

Sourcery is free for open source - if you like our reviews please consider sharing them ✨
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.

@Czaki Czaki changed the title Drop python 3.9 tests for napari repo chore: Drop python 3.9 tests for napari repository Feb 14, 2025
Copy link

codecov bot commented Feb 14, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 93.15%. Comparing base (cc63206) to head (9a7ea84).
Report is 1 commits behind head on develop.

Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #1244      +/-   ##
===========================================
- Coverage    93.16%   93.15%   -0.02%     
===========================================
  Files          210      210              
  Lines        33288    33288              
===========================================
- Hits         31014    31009       -5     
- Misses        2274     2279       +5     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Czaki Czaki merged commit 6253b11 into develop Feb 14, 2025
59 of 67 checks passed
@Czaki Czaki deleted the fix_napari_repo_test branch February 14, 2025 10:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[test-bot] napari repos test fail
1 participant