[DSC-1963] Fixes potential cache issues with rest exposed props

4Science · Oct 11, 2024 · 2d9b275 · 2d9b275
1 parent f21e6f5
commit 2d9b275
Showing 1 changed file with 12 additions and 5 deletions.
diff --git a/...rver-webapp/src/main/java/org/dspace/app/rest/repository/ConfigurationRestRepository.java b/...rver-webapp/src/main/java/org/dspace/app/rest/repository/ConfigurationRestRepository.java
@@ -33,17 +33,21 @@ public class ConfigurationRestRepository extends DSpaceRestRepository<PropertyRe
     private AuthorizeService authorizeService;
 
     private ConfigurationService configurationService;
-    private List<String> exposedProperties;
-    private List<String> adminRestrictedProperties;
 
     @Autowired
     public ConfigurationRestRepository(ConfigurationService configurationService) {
         this.configurationService = configurationService;
-        this.exposedProperties = Arrays.asList(configurationService.getArrayProperty("rest.properties.exposed"));
-        this.adminRestrictedProperties =
-            Arrays.asList(configurationService.getArrayProperty("admin.rest.properties.exposed"));
     }
 
+    protected String[] getExposedProperties() {
+        return configurationService.getArrayProperty("rest.properties.exposed");
+    }
+
+    protected String[] getAdminRestrictedProperties() {
+        return configurationService.getArrayProperty("admin.rest.properties.exposed");
+    }
+
+
     /**
      * Gets the value of a configuration property if it is exposed via REST
      *
@@ -62,6 +66,9 @@ public ConfigurationRestRepository(ConfigurationService configurationService) {
     @Override
     @PreAuthorize("permitAll()")
     public PropertyRest findOne(Context context, String property) {
+        List<String> exposedProperties = Arrays.asList(getExposedProperties());
+        List<String> adminRestrictedProperties = Arrays.asList(getAdminRestrictedProperties());
+
         if (!configurationService.hasProperty(property) ||
             (adminRestrictedProperties.contains(property) && !isCurrentUserAdmin(context)) ||
             (!exposedProperties.contains(property) && !isCurrentUserAdmin(context))) {