Skip to content

Commit

Permalink
Merged in task/dspace-cris-2023_02_x/DSC-1826 (pull request DSpace#2731)
Browse files Browse the repository at this point in the history 
[DSC-1826] adding ITs

Approved-by: Stefano Maffei
  • Loading branch information
@eskander17 @steph-ieffam
eskander17 authored and steph-ieffam committed Oct 2, 2024
2 parents ff0a459 + 57e415a commit cb046ff
Showing 1 changed file with 234 additions and 3 deletions.
237 changes: 234 additions & 3 deletions dspace-server-webapp/src/test/java/org/dspace/app/rest/ScriptRestRepositoryIT.java
View file
Original file line number Diff line number Diff line change
Expand Up @@ -549,6 +549,226 @@ public void findOneScriptByNameLocalAdminsTest() throws Exception {
curateScriptConfiguration.getDescription())));
}

@Test
public void findBulkImportScriptByAdminsTest() throws Exception {
context.turnOffAuthorisationSystem();
EPerson comAdmin = EPersonBuilder.createEPerson(context)
.withEmail("[email protected]")
.withPassword(password).build();
EPerson colAdmin = EPersonBuilder.createEPerson(context)
.withEmail("[email protected]")
.withPassword(password).build();
EPerson itemAdmin = EPersonBuilder.createEPerson(context)
.withEmail("[email protected]")
.withPassword(password).build();
Community community = CommunityBuilder.createCommunity(context)
.withName("Community")
.withAdminGroup(comAdmin)
.build();
Collection collection = CollectionBuilder.createCollection(context, community)
.withName("Collection")
.withAdminGroup(colAdmin)
.build();
ItemBuilder.createItem(context, collection).withAdminUser(itemAdmin)
.withTitle("Test item").build();
context.restoreAuthSystemState();
ScriptConfiguration bulkImportScriptConfiguration =
scriptConfigurations.stream().filter(scriptConfiguration
-> scriptConfiguration.getName().equals("bulk-import"))
.findAny().get();

String comAdminToken = getAuthToken(comAdmin.getEmail(), password);
String colAdminToken = getAuthToken(colAdmin.getEmail(), password);
String itemAdminToken = getAuthToken(itemAdmin.getEmail(), password);
getClient(comAdminToken).perform(get("/api/system/scripts/" + bulkImportScriptConfiguration.getName()))
.andExpect(status().isOk())
.andExpect(jsonPath("$", ScriptMatcher
.matchScript(
bulkImportScriptConfiguration.getName(),
bulkImportScriptConfiguration.getDescription())));
getClient(colAdminToken).perform(get("/api/system/scripts/" + bulkImportScriptConfiguration.getName()))
.andExpect(status().isOk())
.andExpect(jsonPath("$", ScriptMatcher
.matchScript(
bulkImportScriptConfiguration.getName(),
bulkImportScriptConfiguration.getDescription())));
getClient(itemAdminToken).perform(get("/api/system/scripts/" + bulkImportScriptConfiguration.getName()))
.andExpect(status().isForbidden());
}

@Test
public void findBulkAccessControlScriptByAdminsTest() throws Exception {
context.turnOffAuthorisationSystem();
EPerson comAdmin = EPersonBuilder.createEPerson(context)
.withEmail("[email protected]")
.withPassword(password).build();
EPerson colAdmin = EPersonBuilder.createEPerson(context)
.withEmail("[email protected]")
.withPassword(password).build();
EPerson itemAdmin = EPersonBuilder.createEPerson(context)
.withEmail("[email protected]")
.withPassword(password).build();
Community community = CommunityBuilder.createCommunity(context)
.withName("Community")
.withAdminGroup(comAdmin)
.build();
Collection collection = CollectionBuilder.createCollection(context, community)
.withName("Collection")
.withAdminGroup(colAdmin)
.build();
ItemBuilder.createItem(context, collection).withAdminUser(itemAdmin)
.withTitle("Test item").build();
context.restoreAuthSystemState();
ScriptConfiguration scriptConfiguration =
scriptConfigurations.stream().filter(configuration
-> configuration.getName().equals("bulk-access-control"))
.findAny().get();

String comAdminToken = getAuthToken(comAdmin.getEmail(), password);
String colAdminToken = getAuthToken(colAdmin.getEmail(), password);
String itemAdminToken = getAuthToken(itemAdmin.getEmail(), password);
getClient(comAdminToken).perform(get("/api/system/scripts/" + scriptConfiguration.getName()))
.andExpect(status().isOk())
.andExpect(jsonPath("$", ScriptMatcher
.matchScript(
scriptConfiguration.getName(),
scriptConfiguration.getDescription())));
getClient(colAdminToken).perform(get("/api/system/scripts/" + scriptConfiguration.getName()))
.andExpect(status().isOk())
.andExpect(jsonPath("$", ScriptMatcher
.matchScript(
scriptConfiguration.getName(),
scriptConfiguration.getDescription())));
getClient(itemAdminToken).perform(get("/api/system/scripts/" + scriptConfiguration.getName()))
.andExpect(status().isOk())
.andExpect(jsonPath("$", ScriptMatcher
.matchScript(
scriptConfiguration.getName(),
scriptConfiguration.getDescription())));
}

@Test
public void findCollectionExportScriptByAdminsTest() throws Exception {
context.turnOffAuthorisationSystem();
EPerson comAdmin = EPersonBuilder.createEPerson(context)
.withEmail("[email protected]")
.withPassword(password).build();
EPerson colAdmin = EPersonBuilder.createEPerson(context)
.withEmail("[email protected]")
.withPassword(password).build();
EPerson itemAdmin = EPersonBuilder.createEPerson(context)
.withEmail("[email protected]")
.withPassword(password).build();
Community community = CommunityBuilder.createCommunity(context)
.withName("Community")
.withAdminGroup(comAdmin)
.build();
Collection collection = CollectionBuilder.createCollection(context, community)
.withName("Collection")
.withAdminGroup(colAdmin)
.build();
ItemBuilder.createItem(context, collection).withAdminUser(itemAdmin)
.withTitle("Test item").build();
context.restoreAuthSystemState();
ScriptConfiguration scriptConfiguration =
scriptConfigurations.stream().filter(configuration
-> configuration.getName().equals("collection-export"))
.findAny().get();

String comAdminToken = getAuthToken(comAdmin.getEmail(), password);
String colAdminToken = getAuthToken(colAdmin.getEmail(), password);
String itemAdminToken = getAuthToken(itemAdmin.getEmail(), password);
getClient(comAdminToken).perform(get("/api/system/scripts/" + scriptConfiguration.getName()))
.andExpect(status().isOk())
.andExpect(jsonPath("$", ScriptMatcher
.matchScript(
scriptConfiguration.getName(),
scriptConfiguration.getDescription())));
getClient(colAdminToken).perform(get("/api/system/scripts/" + scriptConfiguration.getName()))
.andExpect(status().isOk())
.andExpect(jsonPath("$", ScriptMatcher
.matchScript(
scriptConfiguration.getName(),
scriptConfiguration.getDescription())));
getClient(itemAdminToken).perform(get("/api/system/scripts/" + scriptConfiguration.getName()))
.andExpect(status().isForbidden());
}

@Test
public void findItemExportScriptTest() throws Exception {
ScriptConfiguration scriptConfiguration =
scriptConfigurations.stream().filter(configuration
-> configuration.getName().equals("item-export"))
.findAny().get();

getClient().perform(get("/api/system/scripts/" + scriptConfiguration.getName()))
.andExpect(status().isOk())
.andExpect(jsonPath("$", ScriptMatcher
.matchScript(
scriptConfiguration.getName(),
scriptConfiguration.getDescription())));
}

@Test
public void findBulkItemExportScriptByAdminsTest() throws Exception {
context.turnOffAuthorisationSystem();
EPerson comAdmin = EPersonBuilder.createEPerson(context)
.withEmail("[email protected]")
.withPassword(password).build();
EPerson colAdmin = EPersonBuilder.createEPerson(context)
.withEmail("[email protected]")
.withPassword(password).build();
EPerson itemAdmin = EPersonBuilder.createEPerson(context)
.withEmail("[email protected]")
.withPassword(password).build();
Community community = CommunityBuilder.createCommunity(context)
.withName("Community")
.withAdminGroup(comAdmin)
.build();
Collection collection = CollectionBuilder.createCollection(context, community)
.withName("Collection")
.withAdminGroup(colAdmin)
.build();
ItemBuilder.createItem(context, collection).withAdminUser(itemAdmin)
.withTitle("Test item").build();
context.restoreAuthSystemState();
ScriptConfiguration scriptConfiguration =
scriptConfigurations.stream().filter(configuration
-> configuration.getName().equals("bulk-item-export"))
.findAny().get();

String comAdminToken = getAuthToken(comAdmin.getEmail(), password);
String colAdminToken = getAuthToken(colAdmin.getEmail(), password);
String itemAdminToken = getAuthToken(itemAdmin.getEmail(), password);
String loggedInToken = getAuthToken(eperson.getEmail(), password);
getClient(comAdminToken).perform(get("/api/system/scripts/" + scriptConfiguration.getName()))
.andExpect(status().isOk())
.andExpect(jsonPath("$", ScriptMatcher
.matchScript(
scriptConfiguration.getName(),
scriptConfiguration.getDescription())));
getClient(colAdminToken).perform(get("/api/system/scripts/" + scriptConfiguration.getName()))
.andExpect(status().isOk())
.andExpect(jsonPath("$", ScriptMatcher
.matchScript(
scriptConfiguration.getName(),
scriptConfiguration.getDescription())));
getClient(itemAdminToken).perform(get("/api/system/scripts/" + scriptConfiguration.getName()))
.andExpect(status().isOk())
.andExpect(jsonPath("$", ScriptMatcher
.matchScript(
scriptConfiguration.getName(),
scriptConfiguration.getDescription())));
getClient(loggedInToken).perform(get("/api/system/scripts/" + scriptConfiguration.getName()))
.andExpect(status().isOk())
.andExpect(jsonPath("$", ScriptMatcher
.matchScript(
scriptConfiguration.getName(),
scriptConfiguration.getDescription())));
getClient().perform(get("/api/system/scripts/" + scriptConfiguration.getName()))
.andExpect(status().isUnauthorized());
}

@Test
public void findOneScriptByNameNotAuthenticatedTest() throws Exception {
getClient().perform(get("/api/system/scripts/mock-script"))
Expand All @@ -557,10 +777,21 @@ public void findOneScriptByNameNotAuthenticatedTest() throws Exception {

@Test
public void findOneScriptByNameTestAccessDenied() throws Exception {
String token = getAuthToken(eperson.getEmail(), password);
String[] excludedScripts = new String[] {"curate", "bulk-import",
"item-export", "bulk-item-export", "bulk-access-control",
"collection-export"};

getClient(token).perform(get("/api/system/scripts/mock-script"))
.andExpect(status().isForbidden());
String token = getAuthToken(eperson.getEmail(), password);
scriptConfigurations.stream().filter(scriptConfiguration ->
!StringUtils.equalsAny(scriptConfiguration.getName(), excludedScripts))
.forEach(scriptConfiguration -> {
try {
getClient(token).perform(get("/api/system/scripts/" + scriptConfiguration.getName()))
.andExpect(status().isForbidden());
} catch (Exception e) {
e.printStackTrace();
}
});
}

@Test
Expand Down

0 comments on commit cb046ff

Please sign in to comment.