forked from DSpace/DSpace
-
Notifications
You must be signed in to change notification settings - Fork 63
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Enhancement tools #312
Closed
floriangantner
wants to merge
23
commits into
4Science:main-cris
from
uniba-ub:dspace-cris-7-enhancement
Closed
Enhancement tools #312
floriangantner
wants to merge
23
commits into
4Science:main-cris
from
uniba-ub:dspace-cris-7-enhancement
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Enhance one dc.title from a list of other metadatafields. Language and Security are not considered. Some optional default value can be specified.
extended item enhancer. Items can be limit to entity type or collection. Some pagination (max entries) can be defined for testing and some limit after which some commit to the database is made.
…solr extended item enhancer based on the solr search. Items can be limit to entity type or collection. Some pagination (max entries) can be defined for testing and some limit after which some commit to the database is made. Additional some solr-query can be defined (e.g. enhance all items of some author/matching the query result) and some solr-based date range to only enhance items lastModified between two dates.
enhancer using the result value of some mapConverter file,
saschaszott
reviewed
Jun 29, 2023
saschaszott
reviewed
Jul 3, 2023
dspace-api/src/main/java/org/dspace/content/enhancer/impl/MapConverterValueEnhancer.java
Outdated
Show resolved
Hide resolved
saschaszott
reviewed
Jul 3, 2023
dspace-api/src/main/java/org/dspace/content/enhancer/script/ItemEnhancerEntityTypeScript.java
Outdated
Show resolved
Hide resolved
saschaszott
reviewed
Jul 3, 2023
dspace-api/src/main/java/org/dspace/content/enhancer/script/ItemEnhancerByDateScript.java
Outdated
Show resolved
Hide resolved
call the script without further options; copy of standard tests from ItemEnhancerScriptIT
changes: do not iterate over all entities when some entity type is given, but over all collections with this type which improves performance. More checks on specified collection and entity types.
changes: fix some labels, comment and SearchCore Instantiation for proper tests
[maven-release-plugin] copy for tag dspace-cris-2023.02.02
alignment to 2023.02.02 Release |
test entitytype, collection, limit and max and solr query parameter on the enhancement scripts. lower progress handler infos to debug
provide simple integration test for the nameenhancer using common cris metadatafields
8 tasks
closed, because superseded by #440 |
8 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
References
Description
Instructions for Reviewers
List of changes in this PR:
Enhancers:
Enhancer Scripts:
Include guidance for how to test or review your PR. This may include: steps to reproduce a bug, screenshots or description of a new feature, or reasons behind specific changes.
still working on tests for nameenhancer. possible split in two PR's (enhancer scripts and name enhancer)
Checklist
This checklist provides a reminder of what we are going to look for when reviewing your PR. You need not complete this checklist prior to creating your PR (draft PRs are always welcome). If you are unsure about an item in the checklist, don't hesitate to ask. We're here to help!
pom.xml
), I've made sure their licenses align with the DSpace BSD License based on the Licensing of Contributions documentation.