Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Patent entity in orcid Push #430

Closed

Conversation

floriangantner
Copy link

@floriangantner floriangantner commented Feb 27, 2024

References

This PR is based on the #428 PR and should be reviewed/merged afterwards or together to avoid unnecessary merge conflicts.

Description

Support for Orcid Push of Patent Entity. Allow construction of orcid work object from patent entity and support for sync-mode setting change for patent entity.

Instructions for Reviewers

  • new metadata field to hold the sync setting for patent dspace.orcid.sync-patents
  • new OrcidEntityType Patent and corresponding Factory OrcidPatentWorkFactory creating orcid Work objects based on Patent entity.
  • new OrcidPatentWorkFieldMapping to use some entity-specific mapping (fields might differ from publication)
  • extended profile orcid sync preferences operation to support the change of the sync settings for the corresponding profile
  • Tests: copied and aligned tests for creation of the orcid work objects for Patent entity

Checklist

This checklist provides a reminder of what we are going to look for when reviewing your PR. You need not complete this checklist prior to creating your PR (draft PRs are always welcome). If you are unsure about an item in the checklist, don't hesitate to ask. We're here to help!

  • My PR is small in size (e.g. less than 1,000 lines of code, not including comments & integration tests). Exceptions may be made if previously agreed upon.
  • My PR passes Checkstyle validation based on the Code Style Guide.
  • My PR includes Javadoc for all new (or modified) public methods and classes. It also includes Javadoc for large or complex private methods.
  • My PR passes all tests and includes new/updated Unit or Integration Tests based on the Code Testing Guide.
  • If my PR includes new libraries/dependencies (in any pom.xml), I've made sure their licenses align with the DSpace BSD License based on the Licensing of Contributions documentation.
  • If my PR modifies REST API endpoints, I've opened a separate REST Contract PR related to this change.
  • If my PR includes new configurations, I've provided basic technical documentation in the PR itself.
  • If my PR fixes an issue ticket, I've linked them together.

allow construction of orcid work object from product entity and support for sync-mode setting change for product entitiy.
allow construction of orcid work object from patent entity and support for sync-mode setting change for patent entity.
@floriangantner
Copy link
Author

Orcid push for patent has become part of the 2023.02.03 release, thus closing the issue

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Orcid Push for Patent Entity
1 participant