Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ajs fix bugs #580

Merged
merged 5 commits into from
Oct 3, 2024
Merged

Ajs fix bugs #580

merged 5 commits into from
Oct 3, 2024

Conversation

aschroed
Copy link
Member

@aschroed aschroed commented Oct 2, 2024

Fixed bugs in 3 different checks:

  1. in check that looks for reciprocal and complete relationships for the 'grouped with' relationship type the formation of groups was somewhat relationship type agnostic so there were paired fastq files that should not get the grouped with relationship added to groups if other files linked to the pair had that relationship - eg. index reads or barcodes. Added a filter to avoid this incorrect grouping
  2. entrez_gene_id validation would throw and exception if there was no response at all from the ncbi request so added a check to make sure that if that was the case it would be dealt with gracefully
  3. SPIN state files get a tag and higlass_defaults for color a multivec added - the check that dealt with finding files that needed this info updated was very wonky so this PR refactors that code.

@RahiNav
Copy link
Contributor

RahiNav commented Oct 2, 2024

Hi, the local tests for grouped_with_file_relation_consistency and validate_entrez_geneids came back as expected.
For the grouped_with check: {
"name": "grouped_with_file_relation_consistency",
"summary": "All 'grouped with' file relationships are consistent",
"description": "All 'grouped with' file relationships are consistent",
"status": "PASS",......}
For gene_id check:{
"name": "validate_entrez_geneids",
"summary": "",
"description": "GENE IDs are all valid",
"status": "PASS",.....}

@aschroed aschroed merged commit f3fa46a into master Oct 3, 2024
1 check failed
@aschroed aschroed deleted the ajs_fix_bugs branch October 3, 2024 15:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants