Merge pull request #256 from 4dn-dcic/impressions_count

Fix Analytics Impressions for 200+ Items
4dn-dcic · May 27, 2024 · 24739f8 · 24739f8
2 parents 100c00f + 0dcb70d
commit 24739f8
Show file tree

Hide file tree

Showing 4 changed files with 5 additions and 5 deletions.
diff --git a/es/components/util/analytics.js b/es/components/util/analytics.js
@@ -641,7 +641,7 @@ export function impressionListOfItems(itemList) {
   var href = arguments.length > 1 && arguments[1] !== undefined ? arguments[1] : null;
   var listName = arguments.length > 2 && arguments[2] !== undefined ? arguments[2] : null;
   var context = arguments.length > 3 && arguments[3] !== undefined ? arguments[3] : null;
-  if (!shouldTrack(itemList)) return false;
+  if (!shouldTrack(itemList)) return [];
   context = context || state && state.reduxStore && state.reduxStore.getState().context || null;
   var from = 0;
   if (typeof href === 'string') {

diff --git a/package-lock.json b/package-lock.json
diff --git a/package.json b/package.json
@@ -1,6 +1,6 @@
 {
     "name": "@hms-dbmi-bgm/shared-portal-components",
-    "version": "0.1.84",
+    "version": "0.1.85",
     "description": "Shared components used for DBMI/BGM portal(s).",
     "repository": {
         "type": "git",

diff --git a/src/components/util/analytics.js b/src/components/util/analytics.js
@@ -652,7 +652,7 @@ export function transformItemsToProducts(items, extData = {}){
  * @returns {Object[]} Representation of what was sent.
  */
 export function impressionListOfItems(itemList, href = null, listName = null, context = null){
-    if (!shouldTrack(itemList)) return false;
+    if (!shouldTrack(itemList)) return [];
     context = context || (state && state.reduxStore && state.reduxStore.getState().context) || null;
     var from = 0;
     if (typeof href === 'string'){ // Convert to URL parts.