Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade ruby 3.2.2 + rails 7.1.2 #516

Open
wants to merge 15 commits into
base: develop
Choose a base branch
from
Open

Upgrade ruby 3.2.2 + rails 7.1.2 #516

wants to merge 15 commits into from

Conversation

phrase5036
Copy link

No description provided.

@phrase5036
Copy link
Author

@marsz rake spec 跟 rake spec:feature 目前都是過的了

Codeship project setting 有做一個改動
因為 tyr 有自己的 brakeman.ignore 了,寫進來 rails-template 也不太合理,所以就做了排除 tyr 的動作。

# bundle exec brakeman
bundle exec brakeman --skip-files tyr/

@marsz
Copy link
Member

marsz commented Nov 22, 2023

@phrase5036

  1. brakeman 之前我沒有升上去主要是因為 --skip-files 的問題(不想加這個參數),但我想之後就還是加好了,這樣的 brakeman 可以升到最新版本,不用限制在 6 ,除非有其他不可抗因素
  2. db migrate 內的版本號也要改 both tyr & project

@phrase5036
Copy link
Author

phrase5036 commented Nov 22, 2023

@marsz

  1. brakeman 目前最新就是 6.0,就看有沒有要特別指定了。
  2. 好哦,我再補過

@phrase5036
Copy link
Author

@marsz Migrations 版本皆已更新。

另外上面忘記提到 會升 brakeman 是因為他 4 的版本 會跟 rubocop 會打架
Hash Value Omission
rubocop 會希望修掉,但是4版 brakeman 會視為是 error 。

截圖 2023-11-23 上午1 40 10

@marsz
Copy link
Member

marsz commented Nov 23, 2023

@phrase5036 tyr 我有 update 了
這個專案你再 update tyr 後就可以 clone 到權利回復了

我想一下專案名稱、開好 repo 後你再來 clone

@phrase5036
Copy link
Author

@marsz 新增了 commit,並且同步更新 tyr。

主要修正 rails s 啟動遇到的錯誤

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants