Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create lotus-stage.json #158

Closed
wants to merge 1 commit into from
Closed

Conversation

tarunbalaji3
Copy link

New Stylesheet Submission:

  • [] Have you followed the guidelines in our Contributing document?
  • [] Have you checked to ensure there aren't other files using the same name as yours?
  • [] Have you filled in at least the required data for title, author, and stylesheet?
  • [] Is the value of stylesheet a full URL that is publicly accessible and renders an unminified, compiled CSS file?
  • [] Do your styles pass proper contrast for accessibility?
  • [] Have you included @media (prefers-reduced-motion: reduce) to remove animations on *,*::before,*::after?
  • [] Did you style the .skip-link?
  • [] Have you checked on a real mobile device to ensure your responsive design doesn't cause overlaps or overflow scrolling?

@github-actions
Copy link

👋 Thanks for participating! I will review as soon as possible, usually within a few hours.

Watch for notifications as I may request some small changes to make sure this meets the guidelines.

In a few minutes, the Netlify process at the end of this PR will make a preview available. Look for the message "Deploy preview ready!" then click the "Details" link next to it to launch a preview of your styles. Make changes if needed, and comment if you do so I can re-deploy the preview. Note that the "sponsor footer" is not available to fully style, but you may fix any issues it causes to your layout.

Thanks again, I hope you learned something while making your stylesheet! 💫

@github-actions github-actions bot added problem detected Bot has detected an potential problem with the submission stylesheet submission labels Dec 17, 2022
@5t3ph
Copy link
Owner

5t3ph commented Dec 23, 2022

@tarunbalaji3 nice work!

Unfortunately, the black text on the dark red doesn't pass contrast:
image

Since you are using a gradient you'll need to manually check the contrast at different points to ensure it is 4.5 or better between the background and the text color. One idea is to put a solid background color behind the text and keep the gradient for the page background.

Let me know when you've resolved the contrast in your stylesheet and I'll update the preview!

@5t3ph
Copy link
Owner

5t3ph commented Jun 16, 2023

@tarunbalaji3 closing for now but if you find time to address the contrast, please re-submit, thanks!

@5t3ph 5t3ph closed this Jun 16, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
problem detected Bot has detected an potential problem with the submission stylesheet submission
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants