Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tour-in-rio #161

Closed
wants to merge 3 commits into from
Closed

tour-in-rio #161

wants to merge 3 commits into from

Conversation

Maujor
Copy link

@Maujor Maujor commented Dec 19, 2022

New Stylesheet Submission:

  • [] Have you followed the guidelines in our Contributing document?
  • [] Have you checked to ensure there aren't other files using the same name as yours?
  • [] Have you filled in at least the required data for title, author, and stylesheet?
  • [] Is the value of stylesheet a full URL that is publicly accessible and renders an unminified, compiled CSS file?
  • [] Do your styles pass proper contrast for accessibility?
  • [] Have you included @media (prefers-reduced-motion: reduce) to remove animations on *,*::before,*::after?
  • [] Did you style the .skip-link?
  • [] Have you checked on a real mobile device to ensure your responsive design doesn't cause overlaps or overflow scrolling?

@github-actions
Copy link

👋 Thanks for participating! I will review as soon as possible, usually within a few hours.

Watch for notifications as I may request some small changes to make sure this meets the guidelines.

In a few minutes, the Netlify process at the end of this PR will make a preview available. Look for the message "Deploy preview ready!" then click the "Details" link next to it to launch a preview of your styles. Make changes if needed, and comment if you do so I can re-deploy the preview. Note that the "sponsor footer" is not available to fully style, but you may fix any issues it causes to your layout.

Thanks again, I hope you learned something while making your stylesheet! 💫

@github-actions github-actions bot added stylesheet submission problem detected Bot has detected an potential problem with the submission labels Dec 19, 2022
@Maujor
Copy link
Author

Maujor commented Dec 20, 2022

May I know what is wrong with my submission?

@5t3ph
Copy link
Owner

5t3ph commented Dec 23, 2022

@Maujor I appreciate the creativity with this one!

Unfortunately, the image in this section is so detailed it makes the text hard to read. Perhaps you can add some top padding to include the image within so that it's not directly behind the text?
image

Additionally, these buttons have too low of contrast. With that text size and the bold it will need to be over 3 at the least:
image

Finally, there are some content overlap issues for small (mobile) viewports:
image

@Maujor
Copy link
Author

Maujor commented Dec 23, 2022

@5t3ph Thanks for advices!
I fixed the issues, Please have a look.
Merry Christmas.

From Copyright mark to Registered mark after Maujor nickname.
@5t3ph
Copy link
Owner

5t3ph commented Jan 18, 2023

@Maujor I see the update to the background image, but the mobile styles still have some trouble spots. Please check the site down to at least 375px wide and resolve any issues you see with overlapping content or content breaking out of the designs (like the cloud images).

The contrast on the "buttons" has also gotten a bit worse as well. If you change your opacity from 0.6 to 0.65 it will pass contrast!

@5t3ph
Copy link
Owner

5t3ph commented Jun 16, 2023

@Maujor closing for now but if you find time to address my previous comment, please re-submit, thanks!

@5t3ph 5t3ph closed this Jun 16, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
problem detected Bot has detected an potential problem with the submission stylesheet submission
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants