-
Notifications
You must be signed in to change notification settings - Fork 226
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
tour-in-rio #161
tour-in-rio #161
Conversation
👋 Thanks for participating! I will review as soon as possible, usually within a few hours. Watch for notifications as I may request some small changes to make sure this meets the guidelines. In a few minutes, the Netlify process at the end of this PR will make a preview available. Look for the message "Deploy preview ready!" then click the "Details" link next to it to launch a preview of your styles. Make changes if needed, and comment if you do so I can re-deploy the preview. Note that the "sponsor footer" is not available to fully style, but you may fix any issues it causes to your layout. Thanks again, I hope you learned something while making your stylesheet! 💫 |
May I know what is wrong with my submission? |
@Maujor I appreciate the creativity with this one! Unfortunately, the image in this section is so detailed it makes the text hard to read. Perhaps you can add some top padding to include the image within so that it's not directly behind the text? Additionally, these buttons have too low of contrast. With that text size and the bold it will need to be over 3 at the least: Finally, there are some content overlap issues for small (mobile) viewports: |
@5t3ph Thanks for advices! |
From Copyright mark to Registered mark after Maujor nickname.
@Maujor I see the update to the background image, but the mobile styles still have some trouble spots. Please check the site down to at least 375px wide and resolve any issues you see with overlapping content or content breaking out of the designs (like the cloud images). The contrast on the "buttons" has also gotten a bit worse as well. If you change your opacity from |
@Maujor closing for now but if you find time to address my previous comment, please re-submit, thanks! |
New Stylesheet Submission:
title
,author
, andstylesheet
?stylesheet
a full URL that is publicly accessible and renders an unminified, compiled CSS file?@media (prefers-reduced-motion: reduce)
to remove animations on*,*::before,*::after
?.skip-link
?