Fix tests and command line tool #143
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ChriMarMe
reviewed
Jul 31, 2020
Comment on lines
+53
to
+63
| func systemRunsCoreboot() (bool, error) { | ||
| firmware, err := tools.SMBIOSGetVendor() | ||
| if err != nil { | ||
| return false, err | ||
| } | ||
| if strings.Contains(*firmware, string(test.FWCoreboot)) { | ||
| return true, nil | ||
| } | ||
| return false, nil | ||
| } | ||
|
|
There was a problem hiding this comment.
This does not belong here.
Maybe a new test set for precondition tests, or move this to ACPI tests, because it's only relevant for this tests so far.
There was a problem hiding this comment.
Also a separate commit - "Implementing test to validate if system runs coreboot" or similar
Comment on lines
-127
to
-133
| testnosiniterrors = Test{ | ||
| Name: "SINIT ACM startup successful", | ||
| Required: false, | ||
| NonCritical: true, | ||
| function: NoSINITErrors, | ||
| Status: Implemented, | ||
| } |
| func (t Result) String() string { | ||
| return [...]string{"TESTNOTRUN", "DEPENDENCY_FAILED", "INTERNAL_ERROR", "FAIL", "WARN", "PASS"}[t] |
There was a problem hiding this comment.
Why remove the concept of warn?
There was a problem hiding this comment.
Also separate commit.
Comment on lines
-898
to
+868
| // AutoPromotionModeIsActive checks if TXT is in auto-promotion mode | ||
| func AutoPromotionModeIsActive(txtAPI hwapi.APIInterfaces) (bool, error, error) { | ||
| // TXTModeIsSet checks if a TXT mode is set | ||
| func TXTModeIsSet(txtAPI hwapi.APIInterfaces) (bool, error, error) { | ||
| pol1, pol2, err := readPSLCPPolicy(txtAPI) | ||
| if err != nil { | ||
| return false, nil, err | ||
| } | ||
| if pol1 != nil { | ||
| if pol1.PolicyType != tools.LCPPolicyTypeAny { | ||
| return false, fmt.Errorf("Signed Policy mode active"), nil | ||
| return true, fmt.Errorf("Signed Policy mode active"), nil | ||
| } | ||
| } | ||
| if pol2 != nil { | ||
| if pol2.PolicyType != tools.LCPPolicyTypeAny { | ||
| return false, fmt.Errorf("Signed Policy mode active"), nil | ||
| } | ||
| } | ||
| return true, nil, nil | ||
| } | ||
|
|
||
| // SignedPolicyModeIsActive checks if TXT is in signed policy mode | ||
| func SignedPolicyModeIsActive(txtAPI hwapi.APIInterfaces) (bool, error, error) { | ||
| pol1, pol2, err := readPSLCPPolicy(txtAPI) | ||
| if err != nil { | ||
| return false, nil, err | ||
| } | ||
| if pol1 != nil { | ||
| if pol1.PolicyType != tools.LCPPolicyTypeList { | ||
| return false, fmt.Errorf("Auto-promotion mode active"), nil | ||
| return true, fmt.Errorf("Auto-promotion mode active"), nil | ||
| } | ||
| } | ||
| if pol2 != nil { | ||
| if pol2.PolicyType != tools.LCPPolicyTypeAny { | ||
| return true, fmt.Errorf("Signed Policy mode active"), nil | ||
| } | ||
| if pol2.PolicyType != tools.LCPPolicyTypeList { | ||
| return false, fmt.Errorf("Auto-promotion mode active"), nil | ||
| return true, fmt.Errorf("Auto-promotion mode active"), nil |
There was a problem hiding this comment.
Why we dont keep the granularity?
There was a problem hiding this comment.
Maybe you guessed it ;) Separate commit
PatrickRudolph
requested changes
Aug 3, 2020
| @@ -287,7 +286,7 @@ func IBBIsTrusted(txtAPI hwapi.APIInterfaces) (bool, error, error) { | |||
| if regs.BootStatus&(1<<59) != 0 && regs.BootStatus&(1<<63) != 0 { | |||
| return true, nil, nil | |||
| } | |||
| return false, fmt.Errorf("IBB not trusted"), err | |||
| return true, fmt.Errorf("IBB not trusted, MLE not running"), err | |||
There was a problem hiding this comment.
That's impossible. If something returns true all error must be nil.
| @@ -19,6 +19,7 @@ var ( | |||
| Required: true, | |||
| function: CheckRSDPValid, | |||
| Status: Implemented, | |||
| Firmware: FWNoCoreboot, | |||
There was a problem hiding this comment.
The new Field Firmware is just wrong, whatever it does. That's not clear from the commit message.
| ) | ||
|
|
||
| // SMBIOSGetVendor gets the vendor name from table 0 | ||
| func SMBIOSGetVendor() (*string, error) { |
There was a problem hiding this comment.
that must be astracted over the hwapi.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See #142