Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ci(docker): stop removing old containers #536

Merged
merged 1 commit into from
Jan 30, 2025
Merged

ci(docker): stop removing old containers #536

merged 1 commit into from
Jan 30, 2025

Conversation

AtomicFS
Copy link
Collaborator

@AtomicFS AtomicFS commented Jan 30, 2025 •
edited
Loading

  • currently have a issue with Docker being unable to pull some containers (docker fails to pull containers #549 )
  • maybe there is a bug in this step for removing old contianers causing problems, we could try to temporarily remove it

@AtomicFS AtomicFS requested a review from MDr164 as a code owner January 30, 2025 11:13
@github-actions github-actions bot added the github_actions Pull requests that update GitHub Actions code label Jan 30, 2025
@AtomicFS AtomicFS enabled auto-merge January 30, 2025 11:14
MDr164
MDr164 reviewed Jan 30, 2025
View reviewed changes
Copy link
Collaborator

@MDr164 MDr164 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you just comment that part of the yaml file out, given that we are not yet sure if that is actually the issue?

@AtomicFS
Copy link
Collaborator Author

Fair enough. How about I move it to separate file?

@MDr164
Copy link
Collaborator

MDr164 commented Jan 30, 2025

Fair enough. How about I move it to separate file?

Sounds good

@AtomicFS AtomicFS force-pushed the ci/stop-removing-old-containers branch from 1922fe1 to c554eb2 Compare January 30, 2025 11:52
@AtomicFS AtomicFS requested a review from MDr164 January 30, 2025 11:52
@AtomicFS AtomicFS force-pushed the ci/stop-removing-old-containers branch from c554eb2 to 65239b4 Compare January 30, 2025 13:05
@AtomicFS AtomicFS force-pushed the ci/stop-removing-old-containers branch from 65239b4 to 1535b98 Compare January 30, 2025 13:08
@AtomicFS AtomicFS added this pull request to the merge queue Jan 30, 2025
Merged via the queue into main with commit 1ee5926 Jan 30, 2025
55 checks passed
@AtomicFS AtomicFS deleted the ci/stop-removing-old-containers branch January 30, 2025 13:24
@AtomicFS AtomicFS mentioned this pull request Feb 3, 2025
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MDr164 MDr164 MDr164 approved these changes

Assignees
No one assigned
Labels
github_actions Pull requests that update GitHub Actions code
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@AtomicFS @MDr164