ci(docker): increase git commit sha slug to 12 characters #538
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
AtomicFS
commented
Jan 30, 2025
•
AtomicFS
commented
- we are still having some issues with Docker pulling containers (docker fails to pull containers #549 ), maybe increasing the short git commit sha form default 8 characters to 12 will improve things (it will certainly decrease the likelihood of collision)
github-actions
bot
added
github_actions
|
Now that I am digging into the docker issue, there might be different reason for this. |
|
Never-mind, the thing I was thinking of seems like red herring. |
AtomicFS
force-pushed
the
ci/increase-sha-slug-length
branch
2 times, most recently
from
911d4f1 to
110db52
Compare
- we are still having some issues with Docker pulling containers, maybe increasing the short git commit sha form default 8 characters to 12 will improve things (it will certainly decrease the likelihood of collision) Signed-off-by: AtomicFS <[email protected]>
AtomicFS
force-pushed
the
ci/increase-sha-slug-length
branch
from
110db52 to
39ce883
Compare
MDr164
approved these changes
Jan 31, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.