feat: support change detection in config #592
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
documentation
AtomicFS
force-pushed
the
feat/support-change-detection-in-config
branch
5 times, most recently
from
ec78153 to
a04aafd
Compare
AtomicFS
force-pushed
the
feat/support-change-detection-in-config
branch
from
a04aafd to
7240786
Compare
Signed-off-by: AtomicFS <[email protected]>
- this should hopefully help to reduce copy-pasting for users - I just changed 2 example test to test this feature - the difference is order of the configuration files, for coreboot the target is in first config, while for linux it is in the second Signed-off-by: AtomicFS <[email protected]>
- replace hard-coded code with reflection to make it more flexible AI-Generated: true AI-Model: ChatGPT o3-mini Signed-off-by: AtomicFS <[email protected]>
- add unit-test to validate functionality Signed-off-by: AtomicFS <[email protected]>
- this will make it more flexible when we add more modules in the future - also add unit-test AI-Generated: true AI-Model: ChatGPT o3-mini Signed-off-by: AtomicFS <[email protected]>
Signed-off-by: AtomicFS <[email protected]>
- function to create a safe name for file hopefully in any filesystem on any OS - the module names are user-defined, and since we cannot grantee their sanity, we should sanitize them before using them as file names Signed-off-by: AtomicFS <[email protected]>
Signed-off-by: AtomicFS <[email protected]>
Signed-off-by: AtomicFS <[email protected]>
- since we already have the Filenamify function, lets also use it for the time-stamps, to make it resilient to weird user-inputs Signed-off-by: AtomicFS <[email protected]>
Signed-off-by: AtomicFS <[email protected]>
Signed-off-by: AtomicFS <[email protected]>
AtomicFS
force-pushed
the
feat/support-change-detection-in-config
branch
from
7240786 to
387657b
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There is no test for this. At least not yet.
fixes #543