feat: add goreleaser linting check and replace hardcoded version strings #598
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: AtomicFS <[email protected]>
github-actions
bot
added
testing
AtomicFS
changed the title
Signed-off-by: AtomicFS <[email protected]>
- goreleaser already passes version based on git describe as ldflag along with commit and date - source: https://goreleaser.com/cookbooks/using-main.version/ - the main Taskfile now replicates the same exact behavior as goreleaser - we no longer have to keep these hardcoded strings in sync - when people build from source the version string is much more descriptive Signed-off-by: AtomicFS <[email protected]>
AtomicFS
force-pushed
the
test/add-goreleaser-check
branch
from
5ec848f to
068ab0f
Compare
|
Failing on: With: This is a upstream issue |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update goreleaser configuration
Replace hardcoded version strings
ldflagalong with commit and date (source: https://goreleaser.com/cookbooks/using-main.version/)