plan9: add io/fs.FS implementation #100
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
anastasop
force-pushed
the
add_io_fs_implementation
branch
from
e0a3a0f
to
065af96
Compare
From https://pkg.go.dev/io#Reader Implementations of Read are discouraged from returning a zero byte count with a nil error, except when len(p) == 0. Callers should treat a return return of 0 and nil as indicating that nothing happened; in particular it does not indicate EOF.
Tests run only on linux and need u9fs (https://github.com/unofficial-mirror/u9fs). Runs with go test -tags u9fs
anastasop
force-pushed
the
add_io_fs_implementation
branch
from
065af96
to
d462b6d
Compare
bwsd0
reviewed
May 12, 2023
| mode |= fs.ModeDir | ||
| } | ||
|
|
||
| // The following are not defined by 9p (http://9p.io/sys/man/5/INDEX.html) |
There was a problem hiding this comment.
These file modes are provided by an informal protocol extension called 9p2000.u. The file modes only need to be checked if use of 9p2000.u was agreed after protocol version negotiation. See version(9p).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
An implementation of io/fs.FS for 9p. Tested with http.FileServer.