Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make 2-1 chord via Ctrl-Button1 work under X. #602

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Commits on Jan 15, 2024

  1. Make 2-1 chord via Ctrl-Button1 work under X.

    I noticed that, when Acme runs on MacOS X, I can simulate 2-1 chord as
    follows:
    
    1. Press and hold Option key on the keyboard.
    2. (while holding down Option) press mouse button 1.
    3. Release Option.
    4. Release mouse button 1.
    
    However, under X, the analogous chord with Control didn't work for me.
    I believe the reason is that Button1 never gets "pressed" when the
    sequence of events I described above is processed by code in
    x11-screen.c.  I arrived at that conclusion by "walking through" the
    code as it processes events in my head.
    
    This PR contains one possible way to remedy the situation.  The
    drawback is that, if someone were to do Ctrl-Button2, they'd get a
    spurious 2-1 chord, but I think that may be acceptable.
    zhenya-1007 committed Jan 15, 2024
    Configuration menu
    Copy the full SHA
    897d3c1 View commit details
    Browse the repository at this point in the history