Remove on.create Trigger #118
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
References ACCESS-NRI/model-config-tests#92
Background
We currently have a scenario in configs repositories where we push a branch and open a pull request (quite a common occurence) which is associated with two event triggers:
on.createandon.pull_request.types.opened. These are both associated with the same commit.When the
on.pull_request.types.openedevent fires, which starts the QA/Repro checks, a check run is generated that contains the test results.Unfortunately, having multiple event triggers when adding a check run makes the run associated with either the
on.createtrigger or theon.pull_requesttrigger, nondeterministically. See https://github.com/orgs/community/discussions/24616. This means that sometimes, in the first commit of a PR, we do not get the results of the QA/Repro checks.Since the workarounds are quite painful, we are just removing the
on.createtrigger. This means that it will be a bit more onerous to do the initialrelease-*branch creation. It is essentially a revert of ACCESS-NRI/model-config-tests#58