Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add netcdf conversion to preindustrial configuration #62

Merged
merged 6 commits into from
Aug 23, 2024

Conversation

blimlim
Copy link

@blimlim blimlim commented Aug 23, 2024

This pull request adds the um2nc based netcdf conversion as a postscript to the preindustrial configuration. Fields file deletion is switched on by default.

aidanheerdegen
aidanheerdegen previously approved these changes Aug 23, 2024
Copy link
Member

@aidanheerdegen aidanheerdegen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a suggestion to add a comment in the script. It can be very hard to find where the original code lives, so a pointer here could save someone a lot of time.

Copy link
Member

@aidanheerdegen aidanheerdegen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great. Thanks!

@blimlim blimlim merged commit 61e49d2 into dev-preindustrial+concentrations Aug 23, 2024
11 checks passed
@aidanheerdegen aidanheerdegen deleted the 59-PI-add-nc-conversion branch August 25, 2024 11:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants