Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Updated 'deploy.yml' for testing. #2

Merged
merged 15 commits into from
Aug 20, 2024
Merged

Updated 'deploy.yml' for testing. #2

merged 15 commits into from
Aug 20, 2024

Conversation

atteggiani
Copy link
Collaborator

Added deploy.yml for environment deployment.

@atteggiani atteggiani force-pushed the update_deploy branch 4 times, most recently from d8e1376 to 6ba6882 Compare August 14, 2024 05:05
@atteggiani atteggiani marked this pull request as draft August 15, 2024 00:25
@CodeGat CodeGat marked this pull request as ready for review August 18, 2024 23:28
CodeGat
CodeGat previously approved these changes Aug 19, 2024
View reviewed changes
Copy link
Contributor

@CodeGat CodeGat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Verified that the deployment and modulefile update worked on a test directory

@CodeGat CodeGat requested a review from jo-basevi August 19, 2024 04:02
@CodeGat
Copy link
Contributor

CodeGat commented Aug 19, 2024

Updated environment variables to:

NAME             VALUE                                      UPDATED               
APPS_DIR         /g/data/vk83/apps                          about 1 minute ago
ENVIRONMENT_DIR  /g/data/vk83/apps/conda/access-ram         less than a minute ago
MODULE_DIR       /g/data/vk83/modules/conda/access-ram      less than a minute ago
PACK_DIR         /scratch/tm70/tm70_ci/access-ram-condaenv  about 1 hour ago

jo-basevi
jo-basevi previously approved these changes Aug 19, 2024
View reviewed changes
Copy link
Collaborator

@jo-basevi jo-basevi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes look good to me! Thanks @CodeGat and @atteggiani! Just a couple tiny notes.

README.md might need to be updated:

   module use /g/data/<PROJECT_TO_BE_DEFINED>/modules
   module load access-ram3

.github/workflows/deploy.yml Show resolved Hide resolved
.github/workflows/update-module.yml Outdated Show resolved Hide resolved
@CodeGat CodeGat dismissed stale reviews from jo-basevi and themself via de5954f August 19, 2024 05:52
@CodeGat CodeGat requested a review from jo-basevi August 19, 2024 05:52
jo-basevi
jo-basevi approved these changes Aug 20, 2024
View reviewed changes
Copy link
Collaborator

@jo-basevi jo-basevi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@CodeGat CodeGat merged commit 607b33e into main Aug 20, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@CodeGat CodeGat CodeGat left review comments

@jo-basevi jo-basevi jo-basevi approved these changes

Assignees

@CodeGat CodeGat

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@atteggiani @CodeGat @jo-basevi