Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

added spack_config and spack_package data #104

Merged
merged 5 commits into from
Jul 8, 2024
Merged

Conversation

utkarshgupta95
Copy link
Contributor

@CodeGat CodeGat self-requested a review July 2, 2024 00:56
@CodeGat
Copy link
Contributor

CodeGat commented Jul 2, 2024

Thanks @utkarshgupta95 - I might add some commits as well so the workflow works

CodeGat
CodeGat previously approved these changes Jul 3, 2024
Copy link
Contributor

@CodeGat CodeGat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The stuff that @utkarshgupta95 has done looks good. I'll need someone to verify that my stuff is good, as well. Did you test the upload on the test database?

Copy link
Member

@aidanheerdegen aidanheerdegen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a minor quibble about naming

scripts/generate-build-metadata.bash Outdated Show resolved Hide resolved
tools/release_provenance/models.py Outdated Show resolved Hide resolved
tools/release_provenance/save_release.py Outdated Show resolved Hide resolved
tools/release_provenance/test_release_data.json Outdated Show resolved Hide resolved
@utkarshgupta95
Copy link
Contributor Author

@aidanheerdegen just to confirm spack_packages is not an array?

Copy link
Member

@aidanheerdegen aidanheerdegen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great, thanks!

@utkarshgupta95 utkarshgupta95 merged commit e34fda7 into main Jul 8, 2024
2 checks passed
@utkarshgupta95 utkarshgupta95 deleted the spack-provenance branch July 8, 2024 02:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add fields for spack-packages version and spack-config version to the model table
3 participants