-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
added spack_config and spack_package data #104
Conversation
Thanks @utkarshgupta95 - I might add some commits as well so the workflow works |
8dc4968
to
0416a97
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The stuff that @utkarshgupta95 has done looks good. I'll need someone to verify that my stuff is good, as well. Did you test the upload on the test database?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just a minor quibble about naming
tests/scripts/generate-build-metadata/valid/build_metadata.json
Outdated
Show resolved
Hide resolved
@aidanheerdegen just to confirm |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great, thanks!
resolves ACCESS-NRI/experiment-metadb#15