Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

* Test Results Check Runs Are Not Being Shown In PRs #92

Open
CodeGat opened this issue Jan 21, 2025 · 1 comment
Open

* Test Results Check Runs Are Not Being Shown In PRs #92

CodeGat opened this issue Jan 21, 2025 · 1 comment
Assignees
Labels
priority:high type:bug type:infra Dealing with CI/CD Pipelines

Comments

@CodeGat
Copy link
Member

CodeGat commented Jan 21, 2025

Background

Currently, the first commit of every pull request in a configs repository is not having it's QA/Repro test results showing up in the pull request.

This is due to the test parser (EnricoMi/publish-unit-test-result-action/composite) publishing a check to the incorrect check suite - one trigged by the skipped on.create one rather than the on.pull_request one. See https://github.com/ACCESS-NRI/access-om3-configs/runs/35903426318 - there is a on.pull_request suite and an on.create one. This is due to EnricoMi/publish-unit-test-result-action#12 which is in and of itself an issue with GitHub (see https://github.com/orgs/community/discussions/24616).

Workaround

The actual check run still exists in the logs, but it is difficult to get to. And it doesn't prevent merging.

Implementation Details

Currently there is no good work around for us. Either we revert the on.create trigger PR (since we don't have any leeway on constraining what is created), which means that we will no longer have an easy time with the initial release branch creations, or we find a workaround for publishing the created check to the on.pull_request check to the correct check suite.

@CodeGat
Copy link
Member Author

CodeGat commented Jan 30, 2025

Looks like there is a workaround with https://github.com/orgs/community/discussions/24616#discussioncomment-5607870 but it requires creating a GitHub App and installing into each configs repository, then using the app token to access the check_suites part of the API (which is inaccessible using GITHUB_TOKEN, for some reason!), and then adding check suites and runs manually. This seems like too much infrastructure for too little gain, so the best solution at the moment is to revert the on.create trigger for our config repositories, and go back to the old way.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
priority:high type:bug type:infra Dealing with CI/CD Pipelines
Projects
None yet
Development

No branches or pull requests

1 participant