Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Addition of generic workflows from ACCESS-NRI/reproducibility #26

Merged
merged 1 commit into from
Jun 11, 2024

Conversation

CodeGat
Copy link
Collaborator

@CodeGat CodeGat commented Jun 11, 2024

In this PR:

References #23

@CodeGat CodeGat self-assigned this Jun 11, 2024
Copy link

codecov bot commented Jun 11, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 14.44%. Comparing base (213dd71) to head (9d3c1b1).
Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main      #26      +/-   ##
==========================================
+ Coverage   14.36%   14.44%   +0.07%     
==========================================
  Files          11       11              
  Lines         550      547       -3     
==========================================
  Hits           79       79              
+ Misses        471      468       -3     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@CodeGat CodeGat marked this pull request as ready for review June 11, 2024 05:47
Copy link
Collaborator

@jo-basevi jo-basevi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. Is the documentation on these workflows (that was in reproducibility README) being added in subsequent PR's?

@CodeGat
Copy link
Collaborator Author

CodeGat commented Jun 11, 2024

I'll be taking inspiration from them, yes. I'm not certain of their final form as maybe certain parts of the reusable workflows can be more tightly integrated in the other workflows. See #24 for the final form of these things

@CodeGat CodeGat merged commit c025d99 into main Jun 11, 2024
8 checks passed
@CodeGat CodeGat deleted the 23-add-repro-infra branch June 11, 2024 06:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants