Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes for ACCESS-ESM1.5 Config Tests #43

Merged
merged 4 commits into from
Aug 12, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion pyproject.toml
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
[project]
name = "model_config_tests"
version = "0.0.3"
version = "0.0.4"
authors = [
{ name = "ACCESS-NRI" },
]
Expand Down
10 changes: 7 additions & 3 deletions src/model_config_tests/qa/test_access_esm1p5_config.py
Original file line number Diff line number Diff line change
Expand Up @@ -24,9 +24,9 @@
VALID_KEYWORDS: set[str] = {"global", "access-esm1.5"}
VALID_NOMINAL_RESOLUTION: str = "100 km"
VALID_REFERENCE: str = "https://doi.org/10.1071/ES19035"
VALID_PREINDUSTRIAL_START: dict[str, int] = {"year": 101, "month": 1, "day": 1}
VALID_HISTORICAL_START: dict[str, int] = {"year": 1850, "month": 1, "day": 1}
VALID_RUNTIME: dict[str, int] = {"year": 1, "month": 0, "day": 0}
VALID_PREINDUSTRIAL_START: dict[str, int] = {"year": 101, "month": 1, "days": 1}
VALID_HISTORICAL_START: dict[str, int] = {"year": 1850, "month": 1, "days": 1}
VALID_RUNTIME: dict[str, int] = {"years": 1, "months": 0, "days": 0}
truth-quark marked this conversation as resolved.
Show resolved Hide resolved
VALID_RESTART_FREQ: str = "10YS"
VALID_MPPNCCOMBINE_EXE: str = "mppnccombine.spack"

Expand Down Expand Up @@ -181,6 +181,10 @@
"collate.exe", "config.yaml", VALID_MPPNCCOMBINE_EXE
)

assert "mpi" in config["collate"], error_field_nonexistence(

Check warning on line 184 in src/model_config_tests/qa/test_access_esm1p5_config.py

View check run for this annotation

Codecov / codecov/patch

src/model_config_tests/qa/test_access_esm1p5_config.py#L184

Added line #L184 was not covered by tests
CodeGat marked this conversation as resolved.
Show resolved Hide resolved
"collate.mpi", "config.yaml"
)

assert config["collate"]["mpi"], error_field_incorrect(
"collate.mpi", "config.yaml", "true"
)
Loading