Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ACCESS-ESM1.5 Further Test Fixes #45

Merged
merged 3 commits into from
Aug 12, 2024
Merged

Conversation

CodeGat
Copy link
Collaborator

@CodeGat CodeGat commented Aug 12, 2024

After testing the metadata.yaml tests on an actual ESM1.5 configuration, it was found that more expected fields were actually incorrect.

In this PR:

  • Change 'ocnBgchm' to 'ocnBgchem'
  • Change 'keyword' to 'keywords'
  • Update version of model-config-tests to 0.0.5

@CodeGat CodeGat self-assigned this Aug 12, 2024
Copy link

codecov bot commented Aug 12, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 73.48%. Comparing base (b252873) to head (8f2fb04).
Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main      #45   +/-   ##
=======================================
  Coverage   73.48%   73.48%           
=======================================
  Files          15       15           
  Lines         724      724           
=======================================
  Hits          532      532           
  Misses        192      192           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@aidanheerdegen aidanheerdegen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@CodeGat CodeGat merged commit 26fc4d5 into main Aug 12, 2024
8 checks passed
@CodeGat CodeGat deleted the access-esm1p5-more-test-fixes branch August 12, 2024 06:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants