-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add schema for checksum files used in model repro CI checks #5
Conversation
Open questions:
Similar thing I am unsure about is having a At this stage I've left the const fields out, as I think they are error prone but I can add them back in. As there isn't anything access-om2 specific in the schema, yet, it could actually be more generic? Like |
I reckon leaving the |
Is the Are we just keeping the most recent major version as a file in the repo and relying on |
As to your second question, I think I recall Jo saying that there would be a file per version in the repo. I think this tracks with what @harshula said about discoverability.
|
The filename for any particular version is unique. So we don't need to use tags? |
I had a change of heart about implementing a proper directory structure. I think we should start with any new schemas we add, and we can slot the existing schema into directories at a later date. Here is a proposal, but suggestions/discussion is welcome
There is an argument that this might make schema less discoverable .. the utility probably increases as the number of schema increases. To get the categorical juices flowing, schema.org's hierarchy might be useful |
I feel like putting the model at the top of the hierarchy would be best. Because we can have a
|
I think we've decided to adopt schemaver in the absence of anything else and because it seems well thought out and designed. If we wanted to have a schema server in the future then it might be prudent to organise it the way the snowplow folks have done. They organise their schema like so
e.g. Maybe So version string is Maybe we need a schema for the version string? (THAT IS A JOKE THAT ISN'T FUNNY) |
I vibe with it. Will make those changes. |
…, removed requirement of tagging schema version
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm approving so you can merge if you think it's ok, but I do, as always, have questions.
au.org.access-nri/model/access-om2/experiment/reproducibility/checksums/1-0-0.json
Show resolved
Hide resolved
au.org.access-nri/model/access-om2/experiment/reproducibility/checksums/1-0-0.json
Show resolved
Hide resolved
So according to this, the https://snowplow.io/blog/introducing-self-describing-jsons/ I don't think we need to go that far just yet. We can add it in for later versions if necessary. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
This PR is for adding checksum schema used in model reproducibility tests for ACCESS-OM2 model configs, in this PR: ACCESS-NRI/access-om2-configs#2
This is also a test of an implementation for schema versioning in this issue #4