-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
access-om3-nuopc: depend on esmf with -fp-model precise #132
Conversation
harshula
commented
Jul 31, 2024
- Also, use when="%intel"
Hi @anton-seaice , You can put your notes from testing, here. |
Fixes: ACCESS-NRI/ACCESS-OM3#9 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
I built access-om3 using this spack-packages and the ACCESS-OM3 environment @ 3-spack-yaml-versioning (ACCESS-NRI/ACCESS-OM3@e6ae976) Using model-config-tests (@7670f572f1ec3cc3198ebd5b62e7905a2579c5aa) I tried the following checkout MOM6-CICE6, 1deg_jra55do_ryf (@070493071c807e26071062ed14be795f150426de)
changed binary to access-om3-git.2024.04.0_2024.04.0-ut3rlqfs7kapqgn6ksnf75ysbfgchi4k from access-nri build
copy new checksum to testing/checksum
git switch back to spack-packages@main
changed binary to new build (access-om3-git.2024.04.0_2024.04.0-wiv6b2ibiwurjkghhactrpauzcmjmyx5)
Based on COSIMA/access-om3#40, I expected the runs without this PR (i.e. spack-packages@main) to fail the checksum test. Any thoughts @micaeljtoliveira @dougiesquire ? Maybe I didn't build properly? Maybe the test doesn't cover how the bfb repro issue was identified initially? |
I ran the 1deg_jra55do_ryf twice for one day runs, using the build without this change. The md5sum of the cice & mom6 restart files and the diff the restart files from the two runs show they are identical. So basically I can't reproduce the original problem. I wonder if it got fixed somewhere else unrelated to setting this flag? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The restarts are reproducible, so lets merge this. Its possible we don't need to set the flags, but also I doubt there is a downside? So lets go with it