Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

access-om3-nuopc: depend on esmf with -fp-model precise #132

Merged
merged 2 commits into from
Aug 7, 2024
Merged

Conversation

harshula
Copy link
Collaborator

  • Also, use when="%intel"

@harshula
Copy link
Collaborator Author

Hi @anton-seaice , You can put your notes from testing, here.

@harshula
Copy link
Collaborator Author

Fixes: ACCESS-NRI/ACCESS-OM3#9

Copy link
Collaborator

@micaeljtoliveira micaeljtoliveira left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@anton-seaice
Copy link
Contributor

I built access-om3 using this spack-packages and the ACCESS-OM3 environment @ 3-spack-yaml-versioning (ACCESS-NRI/ACCESS-OM3@e6ae976)

Using model-config-tests (@7670f572f1ec3cc3198ebd5b62e7905a2579c5aa) I tried the following

checkout MOM6-CICE6, 1deg_jra55do_ryf (@070493071c807e26071062ed14be795f150426de)
(COSIMA binary, "access-om3-69f719964a27e23deae3923d60af01a081cc3fc0_main-fkzzqnp")

  • model-config-test -m checksum = passes (after setting initial checksum)
  • model-config-test -m checksum_slow = passes

changed binary to

access-om3-git.2024.04.0_2024.04.0-ut3rlqfs7kapqgn6ksnf75ysbfgchi4k from access-nri build

  • model-config-test -m checksum = fail (checksums have changed - no surprise)

copy new checksum to testing/checksum

  • model-config-tests -m "checksum or checksum_slow" = passes

git switch back to spack-packages@main

spack uninstall --dependents esmf
spack concretise -f 
spack install

changed binary to new build (access-om3-git.2024.04.0_2024.04.0-wiv6b2ibiwurjkghhactrpauzcmjmyx5)

  • model-config-test -m checksum = passes
  • model-config-test -m checksum_slow = passes

Based on COSIMA/access-om3#40, I expected the runs without this PR (i.e. spack-packages@main) to fail the checksum test. Any thoughts @micaeljtoliveira @dougiesquire ?

Maybe I didn't build properly? Maybe the test doesn't cover how the bfb repro issue was identified initially?

@anton-seaice
Copy link
Contributor

anton-seaice commented Aug 2, 2024

I ran the 1deg_jra55do_ryf twice for one day runs, using the build without this change. The md5sum of the cice & mom6 restart files and the diff the restart files from the two runs show they are identical. So basically I can't reproduce the original problem. I wonder if it got fixed somewhere else unrelated to setting this flag?

Copy link
Contributor

@anton-seaice anton-seaice left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The restarts are reproducible, so lets merge this. Its possible we don't need to set the flags, but also I doubt there is a downside? So lets go with it

@harshula harshula merged commit ee8b514 into main Aug 7, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

3 participants