Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Spack package for UM vn7.3 #86

Merged
merged 9 commits into from
Apr 23, 2024
Merged

Spack package for UM vn7.3 #86

merged 9 commits into from
Apr 23, 2024

Conversation

penguian
Copy link
Contributor

@penguian penguian commented Mar 27, 2024

Closes issue #70. This is an initial Spack package for UM vn7.3, as a dependency of ACCESS-ESM1.5. See also issue #59.

Builds and installs as um7%intel. There is also an optional um7%oneapi but this has not yet been tested, and is not expected to work at the moment. See this comment to issue #59 for a possible extension to support gcc compilers.

@penguian penguian linked an issue Mar 27, 2024 that may be closed by this pull request
@penguian penguian requested a review from harshula March 27, 2024 05:09
@penguian penguian self-assigned this Mar 27, 2024
@penguian penguian marked this pull request as draft March 27, 2024 05:10
@penguian penguian marked this pull request as ready for review March 27, 2024 06:00
packages/um7/package.py Outdated Show resolved Hide resolved
packages/um7/package.py Outdated Show resolved Hide resolved
@penguian penguian marked this pull request as draft April 18, 2024 21:53
@penguian
Copy link
Contributor Author

Converted to draft while testing the oneapi build, and while waiting for the pull request on UM_v7 to be resolved.

Copy link
Collaborator

@harshula harshula left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed in VC. Also get @rxy900 's feedback.

@penguian
Copy link
Contributor Author

Testing the debug build with each of the following three variant syntaxes:

$ spack install um7 [email protected]%intel
$ spack install [email protected] opt=debug%intel
$ spack install [email protected]%intel opt=debug

consistently fails with the following Spack internal error:

==> Error: Spack concretizer internal error. Please submit a bug report and include the command, environment if applicable and the following error message.
    [email protected]=0-git.682%intel opt=debug is unsatisfiable, errors are:
    internal_error("Reuse version weight used for build package")
    internal_error("imposed hash without imposing all variant values")
    internal_error("must choose a single version to satisfy version constraints")
    internal_error("version weights must exist and be unique")

This appears to be caused by a known issue in Spack itself: spack/spack#38484
See also ACCESS-NRI/ACCESS-OM2#15

@penguian
Copy link
Contributor Author

penguian commented Apr 22, 2024

The failure above is worked around by temporarily adding the following line to packages/um7/package.py:
After

    version("7.3")

add

    version("7.3-working", branch="4-create-a-working-debug-build")

This allows the following commands to succeed:

$ spack install [email protected]%intel
$ spack install [email protected]%intel opt=debug

I have not pushed this temporary change.

@penguian penguian marked this pull request as ready for review April 23, 2024 01:36
@access-hive-bot
Copy link

This pull request has been mentioned on ACCESS Hive Community Forum. There might be relevant details there:

https://forum.access-hive.org.au/t/can-we-allow-rui-yang-to-review-pull-requests-for-access-nri-spack-packages/2054/1

@penguian penguian requested a review from rxy900 April 23, 2024 06:57
@penguian
Copy link
Contributor Author

Hi @rxy900 Please review this merge request.

@penguian
Copy link
Contributor Author

Thanks @rxy900 for the approval. I am also still waiting for your review of https://github.com/ACCESS-NRI/UM_v7/pull/5 to allow opt=debug to work.

@penguian
Copy link
Contributor Author

Merging now.

@penguian penguian merged commit c75ae8b into main Apr 23, 2024
1 check passed
@penguian penguian deleted the 70-spack-package-for-um-vn73 branch April 23, 2024 23:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Development

Successfully merging this pull request may close these issues.

Spack package for UM vn7.3
4 participants