Guard against ESM1.5 file naming collisions #133
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
blimlim
commented
Oct 9, 2024
aidanheerdegen
previously approved these changes
Oct 11, 2024
Co-authored-by: Aidan Heerdegen <[email protected]>
Yep! Only files that get pushed through the conversion are candidates for deletion, and so any files with clashing outputs won't get deleted. |
|
I've just pinged for a re-review – the only change is the typo fix. |
aidanheerdegen
approved these changes
Oct 14, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR closes #124
It adds a new step to the
convert_esm1p5_output_dirfunction, where pairs of(input_path, output_path)tuples are removed prior to the conversion step if theiroutput_paths are not unique, and warns the user when this occurs.