-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ESM1.5 conversion driver, delete inputs upon successful conversion #77
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
truth-quark
reviewed
Aug 20, 2024
truth-quark
reviewed
Aug 20, 2024
Merge branch 'develop' into 49/esm1.5-driver-delete-inputs
truth-quark
reviewed
Aug 20, 2024
truth-quark
reviewed
Aug 20, 2024
truth-quark
reviewed
Aug 20, 2024
truth-quark
reviewed
Aug 20, 2024
truth-quark
reviewed
Aug 20, 2024
truth-quark
approved these changes
Aug 20, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to go!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request would close #49.
In most simulations of ESM1.5, the original fields files aren't very useful once they've been converted to NetCDF. This pull request adds a command line flag
--delete_ff
,-d
, to the conversion driver. When included, the conversion driver will delete the input fields files when they are converted.I've implemented this by adding the deletion as close as possible to the actual conversion:
um2nc-standalone/umpost/conversion_driver_esm1p5.py
Lines 156 to 160 in 379001b
This does bury a bit more I/O in the
convert_fields_file_list
, but I think it seems safe to have it there to try and ensure that the only way a file can be deleted is if the conversion runs without any errors.I also modified the
convert_fields_file_list
tests to check that file deletion is run when requested, and is not run when it is not requested or if there are any errors.Let me know if these changes look ok, any feedback/suggestions are welcome!