-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Split main into separate function and add entry point #83
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think the only thing missing is an entry point CI test to "run" the conversion driver script in a simple fashion.
Do you want to try copying & modifying the old entry point test from the CI.yml here:
2c7b355, and see if it can run the conversion driver script with --help
?
@blimlim I debugged the So something like
|
The problem is with package discovery https://setuptools.pypa.io/en/latest/userguide/package_discovery.html#custom-discovery The package isn't discovered with the current settings because there isn't a Just add one (it can be empty), e.g.
and it should all work as it is now.
|
Doh. We need to also remove the or make the local file channel the first channel to ensure it picks that version up. |
Yeah it picked up the accessnri channel version |
I moved the local file to the first channel and it's working now! |
Quick! Merge before anything changes! ;) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to go!
This PR addresses the ESM1.5 conversion driver part of #81, splitting the
main
block into separatemain()
andparse_args()
functions, which allows for an entry point to be added to thepytproject.toml
file.Adding entry points to
um2netcdf
will be addressed separately in #82.I'm unsure how to test that the entry point is working, and so suggestions on that would be great too!